You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/02/05 10:30:08 UTC

[GitHub] spark pull request #20226: [SPARK-23034][SQL] Override `nodeName` for all *S...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20226#discussion_r165932670
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala ---
    @@ -86,6 +86,9 @@ case class RowDataSourceScanExec(
     
       def output: Seq[Attribute] = requiredColumnsIndex.map(fullOutput)
     
    +  override val nodeName: String =
    --- End diff --
    
    `DataSourceScanExec.nodeName` is defined as `s"Scan $relation ${tableIdentifier.map(_.unquotedString).getOrElse("")}"`, do we really need to overwrite it here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org