You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/10/16 17:52:40 UTC

Review Request 63038: Protect against null value in RoleQuota

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63038/
-----------------------------------------------------------

Review request for Aurora, Kai Huang, Santhosh Kumar Shanmugham, and Stephan Erb.


Repository: aurora


Description
-------

Fix for bug that caused a race condition on the job/env page with exception "quota is not defined".


Diffs
-----

  ui/src/main/js/components/RoleQuota.js 36a69b4c52777995006d105515379d2ed81a62d3 
  ui/src/main/js/components/__tests__/RoleQuota-test.js 57f332d51b4fc264ecf17020e2a75ab6bec9ffcb 


Diff: https://reviews.apache.org/r/63038/diff/1/


Testing
-------

./gradlew ui:lint
./gradlew ui:test

Validated fix in Vagrant.


Thanks,

David McLaughlin


Re: Review Request 63038: Protect against null value in RoleQuota

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63038/#review188173
-----------------------------------------------------------


Ship it!




Master (c446504) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 16, 2017, 5:52 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63038/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2017, 5:52 p.m.)
> 
> 
> Review request for Aurora, Kai Huang, Santhosh Kumar Shanmugham, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix for bug that caused a race condition on the job/env page with exception "quota is not defined".
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/RoleQuota.js 36a69b4c52777995006d105515379d2ed81a62d3 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js 57f332d51b4fc264ecf17020e2a75ab6bec9ffcb 
> 
> 
> Diff: https://reviews.apache.org/r/63038/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> Validated fix in Vagrant.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 63038: Protect against null value in RoleQuota

Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63038/#review188166
-----------------------------------------------------------


Ship it!




Ship It!

- Reza Motamedi


On Oct. 16, 2017, 5:52 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63038/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2017, 5:52 p.m.)
> 
> 
> Review request for Aurora, Kai Huang, Santhosh Kumar Shanmugham, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix for bug that caused a race condition on the job/env page with exception "quota is not defined".
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/RoleQuota.js 36a69b4c52777995006d105515379d2ed81a62d3 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js 57f332d51b4fc264ecf17020e2a75ab6bec9ffcb 
> 
> 
> Diff: https://reviews.apache.org/r/63038/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> Validated fix in Vagrant.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 63038: Protect against null value in RoleQuota

Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63038/#review188180
-----------------------------------------------------------


Ship it!




Ship It!

- Stephan Erb


On Okt. 16, 2017, 7:52 nachm., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63038/
> -----------------------------------------------------------
> 
> (Updated Okt. 16, 2017, 7:52 nachm.)
> 
> 
> Review request for Aurora, Kai Huang, Santhosh Kumar Shanmugham, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix for bug that caused a race condition on the job/env page with exception "quota is not defined".
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/RoleQuota.js 36a69b4c52777995006d105515379d2ed81a62d3 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js 57f332d51b4fc264ecf17020e2a75ab6bec9ffcb 
> 
> 
> Diff: https://reviews.apache.org/r/63038/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> Validated fix in Vagrant.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 63038: Protect against null value in RoleQuota

Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63038/#review188165
-----------------------------------------------------------


Ship it!




Ship It!

- Santhosh Kumar Shanmugham


On Oct. 16, 2017, 10:52 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63038/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2017, 10:52 a.m.)
> 
> 
> Review request for Aurora, Kai Huang, Santhosh Kumar Shanmugham, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix for bug that caused a race condition on the job/env page with exception "quota is not defined".
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/RoleQuota.js 36a69b4c52777995006d105515379d2ed81a62d3 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js 57f332d51b4fc264ecf17020e2a75ab6bec9ffcb 
> 
> 
> Diff: https://reviews.apache.org/r/63038/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> Validated fix in Vagrant.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>