[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1452: [CELEBORN-547] Refactor request related API

["AngersZhuuuu (via GitHub)" <gi...@apache.org>]

AngersZhuuuu commented on code in PR #1452:
URL: https://github.com/apache/incubator-celeborn/pull/1452#discussion_r1178587412


##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1059,7 +1053,7 @@ class LifecycleManager(appId: String, val conf: CelebornConf) extends RpcEndpoin
     }
   }
 
-  private def requestDestroy(endpoint: RpcEndpointRef, message: Destroy): DestroyResponse = {
+  private def requestWorkerDestroy(endpoint: RpcEndpointRef, message: Destroy): DestroyResponse = {

Review Comment:
   Year, should do like this. Let me do this first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org