You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/12 12:40:04 UTC
[GitHub] [flink] YesOrNo828 opened a new pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
YesOrNo828 opened a new pull request #16792:
URL: https://github.com/apache/flink/pull/16792
…tioning interface
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
- Print & BlaskHole connector supoort partitioned table.
## Brief change log
- Inner class PrintSink implement SupportsPartitioning interface
- Inner class BlackHoleSink implement SupportsPartitioning interface
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
}, {
"hash" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 955ea9b07c4e74ada0538976afb71f1103cf2ea7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010)
* 36e361d4e2d633838fae05fbf15930bb2276b55d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
}, {
"hash" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048",
"triggerID" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"triggerType" : "PUSH"
}, {
"hash" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22103",
"triggerID" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 36e361d4e2d633838fae05fbf15930bb2276b55d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048)
* 34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22103)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] YesOrNo828 commented on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
YesOrNo828 commented on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-898385457
@JingsongLi Thank you for your reviewing. Is there anything I should do with this pr before merged?
BTW, should I take care of the status of failure with CI report ? It seemed **test_ci kafka_gelly** has failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897607287
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 17d4e4de180e9ee72e2c0a658cc5dd813b1aa210 (Thu Aug 12 12:42:32 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] YesOrNo828 commented on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
YesOrNo828 commented on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-899926006
> Also please do not squash changes when updating this PR. Just push them directly so that the reviewers can see the changes. The committer who merges this commit will squash all changes for you when merging.
Thanks for your reminding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
}, {
"hash" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048",
"triggerID" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 955ea9b07c4e74ada0538976afb71f1103cf2ea7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010)
* 36e361d4e2d633838fae05fbf15930bb2276b55d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
}, {
"hash" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048",
"triggerID" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 36e361d4e2d633838fae05fbf15930bb2276b55d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] YesOrNo828 commented on a change in pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
YesOrNo828 commented on a change in pull request #16792:
URL: https://github.com/apache/flink/pull/16792#discussion_r689967651
##########
File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/print/table/PrintTableSinkFactory.java
##########
@@ -113,19 +125,35 @@ public ChangelogMode getChangelogMode(ChangelogMode requestedMode) {
@Override
public SinkRuntimeProvider getSinkRuntimeProvider(DynamicTableSink.Context context) {
DataStructureConverter converter = context.createDataStructureConverter(type);
+ staticPartitions.forEach(
+ (key, value) -> {
+ printIdentifier = null != printIdentifier ? printIdentifier + ":" : "";
+ printIdentifier += key + "=" + value;
+ });
Review comment:
Let me add more tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17d4e4de180e9ee72e2c0a658cc5dd813b1aa210 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991)
* 955ea9b07c4e74ada0538976afb71f1103cf2ea7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 955ea9b07c4e74ada0538976afb71f1103cf2ea7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
}, {
"hash" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048",
"triggerID" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"triggerType" : "PUSH"
}, {
"hash" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22103",
"triggerID" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"triggerType" : "PUSH"
}, {
"hash" : "7c7c6b78520a4daa62d0844c063fd68e9bcc9387",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22369",
"triggerID" : "7c7c6b78520a4daa62d0844c063fd68e9bcc9387",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22103)
* 7c7c6b78520a4daa62d0844c063fd68e9bcc9387 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22369)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17d4e4de180e9ee72e2c0a658cc5dd813b1aa210 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991)
* 955ea9b07c4e74ada0538976afb71f1103cf2ea7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #16792:
URL: https://github.com/apache/flink/pull/16792#discussion_r688195897
##########
File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/print/table/PrintTableSinkFactory.java
##########
@@ -126,6 +128,9 @@ public DynamicTableSink copy() {
public String asSummaryString() {
return "Print to " + (stdErr ? "System.err" : "System.out");
}
+
+ @Override
+ public void applyStaticPartition(Map<String, String> partition) {}
Review comment:
I think it is better to print to StaticPartition, we can append it to printIdentifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
}, {
"hash" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048",
"triggerID" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"triggerType" : "PUSH"
}, {
"hash" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 36e361d4e2d633838fae05fbf15930bb2276b55d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048)
* 34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
}, {
"hash" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048",
"triggerID" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"triggerType" : "PUSH"
}, {
"hash" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22103",
"triggerID" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"triggerType" : "PUSH"
}, {
"hash" : "7c7c6b78520a4daa62d0844c063fd68e9bcc9387",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7c7c6b78520a4daa62d0844c063fd68e9bcc9387",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22103)
* 7c7c6b78520a4daa62d0844c063fd68e9bcc9387 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
}, {
"hash" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048",
"triggerID" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"triggerType" : "PUSH"
}, {
"hash" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22103",
"triggerID" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"triggerType" : "PUSH"
}, {
"hash" : "7c7c6b78520a4daa62d0844c063fd68e9bcc9387",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22369",
"triggerID" : "7c7c6b78520a4daa62d0844c063fd68e9bcc9387",
"triggerType" : "PUSH"
}, {
"hash" : "1ef8b6db2cdc1a43002088892bfea6eb2fcf238a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24239",
"triggerID" : "1ef8b6db2cdc1a43002088892bfea6eb2fcf238a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c7c6b78520a4daa62d0844c063fd68e9bcc9387 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22369)
* 1ef8b6db2cdc1a43002088892bfea6eb2fcf238a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24239)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
}, {
"hash" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048",
"triggerID" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"triggerType" : "PUSH"
}, {
"hash" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22103",
"triggerID" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"triggerType" : "PUSH"
}, {
"hash" : "7c7c6b78520a4daa62d0844c063fd68e9bcc9387",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22369",
"triggerID" : "7c7c6b78520a4daa62d0844c063fd68e9bcc9387",
"triggerType" : "PUSH"
}, {
"hash" : "1ef8b6db2cdc1a43002088892bfea6eb2fcf238a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ef8b6db2cdc1a43002088892bfea6eb2fcf238a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c7c6b78520a4daa62d0844c063fd68e9bcc9387 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22369)
* 1ef8b6db2cdc1a43002088892bfea6eb2fcf238a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
}, {
"hash" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048",
"triggerID" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"triggerType" : "PUSH"
}, {
"hash" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22103",
"triggerID" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"triggerType" : "PUSH"
}, {
"hash" : "7c7c6b78520a4daa62d0844c063fd68e9bcc9387",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22369",
"triggerID" : "7c7c6b78520a4daa62d0844c063fd68e9bcc9387",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c7c6b78520a4daa62d0844c063fd68e9bcc9387 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22369)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17d4e4de180e9ee72e2c0a658cc5dd813b1aa210 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
}, {
"hash" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048",
"triggerID" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"triggerType" : "PUSH"
}, {
"hash" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22103",
"triggerID" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"triggerType" : "PUSH"
}, {
"hash" : "7c7c6b78520a4daa62d0844c063fd68e9bcc9387",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22369",
"triggerID" : "7c7c6b78520a4daa62d0844c063fd68e9bcc9387",
"triggerType" : "PUSH"
}, {
"hash" : "1ef8b6db2cdc1a43002088892bfea6eb2fcf238a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24239",
"triggerID" : "1ef8b6db2cdc1a43002088892bfea6eb2fcf238a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1ef8b6db2cdc1a43002088892bfea6eb2fcf238a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24239)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tsreaper commented on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
tsreaper commented on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-899359045
Also please do not squash changes when updating this PR. Just push them directly so that the reviewers can see the changes. The committer who merges this commit will squash all changes for you when merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #16792:
URL: https://github.com/apache/flink/pull/16792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21991",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
}, {
"hash" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22010",
"triggerID" : "955ea9b07c4e74ada0538976afb71f1103cf2ea7",
"triggerType" : "PUSH"
}, {
"hash" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22048",
"triggerID" : "36e361d4e2d633838fae05fbf15930bb2276b55d",
"triggerType" : "PUSH"
}, {
"hash" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22103",
"triggerID" : "34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34cac1a1ea6edbe1a6b388fc8290f77d12d2c79e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22103)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] YesOrNo828 commented on a change in pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
YesOrNo828 commented on a change in pull request #16792:
URL: https://github.com/apache/flink/pull/16792#discussion_r688385609
##########
File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/print/table/PrintTableSinkFactory.java
##########
@@ -126,6 +128,9 @@ public DynamicTableSink copy() {
public String asSummaryString() {
return "Print to " + (stdErr ? "System.err" : "System.out");
}
+
+ @Override
+ public void applyStaticPartition(Map<String, String> partition) {}
Review comment:
Done for print StaticPartition, and added some tests in `PrintTableSinkFactoryTest.java` & `BlackHoleSinkFactoryTest.java`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tsreaper commented on a change in pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
tsreaper commented on a change in pull request #16792:
URL: https://github.com/apache/flink/pull/16792#discussion_r689371465
##########
File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/print/table/PrintTableSinkFactory.java
##########
@@ -113,19 +125,35 @@ public ChangelogMode getChangelogMode(ChangelogMode requestedMode) {
@Override
public SinkRuntimeProvider getSinkRuntimeProvider(DynamicTableSink.Context context) {
DataStructureConverter converter = context.createDataStructureConverter(type);
+ staticPartitions.forEach(
+ (key, value) -> {
+ printIdentifier = null != printIdentifier ? printIdentifier + ":" : "";
+ printIdentifier += key + "=" + value;
+ });
Review comment:
These changes are not covered. Consider adding a test in `PrintConnectorITCase` so that the result shows this `printIdentifier`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16792: [FLINK-23739][table]BlackHoleSink & PrintSink implement SupportsParti…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16792:
URL: https://github.com/apache/flink/pull/16792#issuecomment-897629413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "17d4e4de180e9ee72e2c0a658cc5dd813b1aa210",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17d4e4de180e9ee72e2c0a658cc5dd813b1aa210 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org