You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AdamGS (via GitHub)" <gi...@apache.org> on 2023/11/28 12:53:14 UTC

Re: [PR] Parquet: Make `MetadataLoader` public [arrow-rs]

AdamGS commented on code in PR #5137:
URL: https://github.com/apache/arrow-rs/pull/5137#discussion_r1407712237


##########
parquet/src/arrow/async_reader/metadata.rs:
##########
@@ -198,7 +196,8 @@ impl<F: MetadataFetch> MetadataLoader<F> {
     }
 }
 
-struct MetadataFetchFn<F>(F);
+/// Helper struct to wrap async fetch functions so they can be used with [`MetadataLoader`] through [`MetadataFetch`]
+pub struct MetadataFetchFn<F>(F);

Review Comment:
   I think this is jus a useful utility for users, but it might not be desirable to make it part of the crate's public facing API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org