You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/05/30 14:41:46 UTC

[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #21046: [master] Node elimination graph pass

piotrwolinski-intel commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1141235855

   > Why in two places you added "EliminateCommonNodes" but in one "EliminateCommonNodesPass"?
   > 
   > Do you think it is necessary to have these two as separate entities? Maybe it would be better to use just "EliminateCommonNodes" and add the "ON/OFF" flag there?
   
   Actually it is a mistake on my side, `EliminateCommonNodes` was used during my earlier attempts to make it work and I forgot to change it, so thank You very much for pointing this out!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org