You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/06/10 17:45:24 UTC
[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #937: HDDS-1663. Add datanode to network topology cluster during node regis…
xiaoyuyao commented on a change in pull request #937: HDDS-1663. Add datanode to network topology cluster during node regis…
URL: https://github.com/apache/hadoop/pull/937#discussion_r292115394
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -228,14 +251,27 @@ public RegisteredCommand register(
datanodeDetails.setIpAddress(dnAddress.getHostAddress());
}
try {
+ String location;
+ if (useHostname) {
+ datanodeDetails.setNetworkName(datanodeDetails.getHostName());
+ location = nodeResolve(datanodeDetails.getHostName());
+ } else {
+ datanodeDetails.setNetworkName(datanodeDetails.getIpAddress());
+ location = nodeResolve(datanodeDetails.getIpAddress());
+ }
+ if (location != null) {
Review comment:
Do we need to give a default location like /DEFAULT-RACK here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org