You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/11/03 08:22:03 UTC
[GitHub] [ozone] guihecheng opened a new pull request #2794: HDDS-5923. [Merge rocksdb in datanode]Add DBHandle abstraction over ReferenceCountedDB.
guihecheng opened a new pull request #2794:
URL: https://github.com/apache/ozone/pull/2794
## What changes were proposed in this pull request?
Add DBHandle abstraction over ReferenceCountedDB.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5923
## How was this patch tested?
existing ut.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 merged pull request #2794: HDDS-5923. [Merge rocksdb in datanode]Add DBHandle abstraction over ReferenceCountedDB.
Posted by GitBox <gi...@apache.org>.
mukul1987 merged pull request #2794:
URL: https://github.com/apache/ozone/pull/2794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on a change in pull request #2794: HDDS-5923. [Merge rocksdb in datanode]Add DBHandle abstraction over ReferenceCountedDB.
Posted by GitBox <gi...@apache.org>.
guihecheng commented on a change in pull request #2794:
URL: https://github.com/apache/ozone/pull/2794#discussion_r817272932
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java
##########
@@ -114,10 +114,8 @@ public static void createContainerMetaData(
"Unrecognized schema version for container: " + schemaVersion);
}
- ReferenceCountedDB db =
- new ReferenceCountedDB(store, dbFile.getAbsolutePath());
Review comment:
@mukul1987 Yes, actually we still have it to be a referenced DB inside the following call BlockUtils.addDB().
After we introduced new DatanodeStore definitions, we will have the logic to check whether we want a referenced DB or a RawDB inside BlockUtils.addDB() according to the schema version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 commented on pull request #2794: HDDS-5923. [Merge rocksdb in datanode]Add DBHandle abstraction over ReferenceCountedDB.
Posted by GitBox <gi...@apache.org>.
errose28 commented on pull request #2794:
URL: https://github.com/apache/ozone/pull/2794#issuecomment-960304291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on pull request #2794: HDDS-5923. [Merge rocksdb in datanode]Add DBHandle abstraction over ReferenceCountedDB.
Posted by GitBox <gi...@apache.org>.
guihecheng commented on pull request #2794:
URL: https://github.com/apache/ozone/pull/2794#issuecomment-960521743
@errose28 Oh, yes, Sammi has created a feature branch and I've switched the merge target to that one, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 commented on pull request #2794: HDDS-5923. [Merge rocksdb in datanode]Add DBHandle abstraction over ReferenceCountedDB.
Posted by GitBox <gi...@apache.org>.
errose28 commented on pull request #2794:
URL: https://github.com/apache/ozone/pull/2794#issuecomment-960304291
Thanks for getting started on this huge feature @guihecheng. Do you think it would be better to work on this on a feature branch instead of sending changes directly into master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 commented on pull request #2794: HDDS-5923. [Merge rocksdb in datanode]Add DBHandle abstraction over ReferenceCountedDB.
Posted by GitBox <gi...@apache.org>.
errose28 commented on pull request #2794:
URL: https://github.com/apache/ozone/pull/2794#issuecomment-960304291
Thanks for getting started on this huge feature @guihecheng. Do you think it would be better to work on this on a feature branch instead of sending changes directly into master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on a change in pull request #2794: HDDS-5923. [Merge rocksdb in datanode]Add DBHandle abstraction over ReferenceCountedDB.
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on a change in pull request #2794:
URL: https://github.com/apache/ozone/pull/2794#discussion_r816793729
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java
##########
@@ -114,10 +114,8 @@ public static void createContainerMetaData(
"Unrecognized schema version for container: " + schemaVersion);
}
- ReferenceCountedDB db =
- new ReferenceCountedDB(store, dbFile.getAbsolutePath());
Review comment:
we should still have a refcounted DB here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org