You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/12/01 22:02:14 UTC

[GitHub] [tomcat-jakartaee-migration] DanielThomas opened a new pull request, #41: Avoid bcel thread safety issue

DanielThomas opened a new pull request, #41:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/41

   Allow `ClassConverter` to be used safely in parallel by avoiding `ConcurrentModificationException` from `SyntheticRepository` for the default `getInstance`:
   ```
   java.util.ConcurrentModificationException: (No message provided)
   	at java.util.HashMap.computeIfAbsent(HashMap.java:1221)	
   	at org.apache.bcel.util.SyntheticRepository.getInstance(SyntheticRepository.java:44)	
   	at org.apache.bcel.util.SyntheticRepository.getInstance(SyntheticRepository.java:40)	
   	at org.apache.bcel.classfile.JavaClass.<init>(JavaClass.java:139)	
   	at org.apache.bcel.classfile.ClassParser.parse(ClassParser.java:180)	
   	at org.apache.tomcat.jakartaee.ClassConverter.convertInternal(ClassConverter.java:86)	
   	at org.apache.tomcat.jakartaee.ClassConverter.convert(ClassConverter.java:63)	
   	at org.apache.tomcat.jakartaee.Migration.migrateStream(Migration.java:346)	
   	at org.apache.tomcat.jakartaee.Migration.migrateArchiveStreaming(Migration.java:277)	
   	at org.apache.tomcat.jakartaee.Migration.migrateStream(Migration.java:340)	
   	at org.apache.tomcat.jakartaee.Migration.migrateFile(Migration.java:233)	
   	at org.apache.tomcat.jakartaee.Migration.execute(Migration.java:199)	
   	at org.apache.tomcat.jakartaee.Migration$execute$3.call(Unknown Source)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat-jakartaee-migration] rmaucher commented on pull request #41: Avoid bcel thread safety issue

Posted by GitBox <gi...@apache.org>.
rmaucher commented on PR #41:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/41#issuecomment-1334920596

   Nice trick. I didn't try to reproduce it, but given the stack trace it seems useful. Thanks for the PR. This will be in 1.0.6.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat-jakartaee-migration] rmaucher closed pull request #41: Avoid bcel thread safety issue

Posted by GitBox <gi...@apache.org>.
rmaucher closed pull request #41: Avoid bcel thread safety issue
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/41


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org