[GitHub] [spark] maropu commented on pull request #31461: [SPARK-7768][CORE][SQL] Open UserDefinedType as a Developer API

[GitBox <gi...@apache.org>]

maropu commented on pull request #31461:
URL: https://github.com/apache/spark/pull/31461#issuecomment-776674497


   I feel the @viirya's refactoring looks reasonable to prevent 3rd-party developers from seeing internal structures if we will make it public. We still have any other concern? I read the discussions above and no one seems to be explicitly against it though.
   
   Btw, is it okay to make classes in the `catalyst` package visible (as a developer api) to 3rd-party developers? IIUC they are internally private and most of the existing developer APIs are actually located in the `core` package:
   ```
   $grep -nr "@DeveloperApi" ./catalyst/src/main/scala/org/apache/spark/sql/ | wc -l
          1
   $grep -nr "@DeveloperApi" ./core/src/main/scala/org/apache/spark/sql | wc -l
         32
   ```
   Any policy for that?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org