You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/23 07:10:55 UTC

[GitHub] [pulsar] 315157973 opened a new pull request #7021: fix Duplicated messages are sent to dead letter topic #6960

315157973 opened a new pull request #7021:
URL: https://github.com/apache/pulsar/pull/7021


   
   Fixes #6960
   
   
   ### Motivation
   
   bug fix
   
   ### Modifications
   
   "UnAckedMessageTracker" will call "consumerBase.redeliverUnacknowledgedMessages". There will be 2 steps here: 
   1) Filter out the messages that need to enter the DLQ
   2) The remaining messages will be re-delivered via RedeliverUnacknowledgedMessages request
   
   The problem appeared in the second step, when all messages were filtered out in the first step. If the MessageIdsList received by the broker is empty, it will trigger the reposting of all unackedMessages under this consumer.
   
   Other consumers will consume messages that exceed maxRedeliveryCount again, and then the messages will repeatedly enter DQL
   
   Therefore, if all messages have been filtered out, the RedeliverUnacknowledgedMessages request should not be initiated. Just let "processPossibleToDLQ" send them to DLQ and ack.
   
   ### Verifying this change
   unit test:
   org.apache.pulsar.client.api.DeadLetterTopicTest#testDuplicatedMessageSendToDeadLetterTopic
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #7021: fix Duplicated messages are sent to dead letter topic #6960

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7021:
URL: https://github.com/apache/pulsar/pull/7021


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #7021: fix Duplicated messages are sent to dead letter topic #6960

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7021:
URL: https://github.com/apache/pulsar/pull/7021#issuecomment-637361135


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org