You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jan Kriesten (JIRA)" <ji...@apache.org> on 2007/05/04 09:35:15 UTC
[jira] Created: (WICKET-531) FormComponentLabel and Radio
FormComponentLabel and Radio
----------------------------
Key: WICKET-531
URL: https://issues.apache.org/jira/browse/WICKET-531
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3
Environment: any
Reporter: Jan Kriesten
Since Radio extends WebMarkupContainer instead of FormComponent, it's not possible to set FormComponentLabels for Radio-buttons.
Since it's desireable to be able to click on the label to select a radio-button, it would be nice to change this to reflect that Radio really is a FormComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-531) FormComponentLabel and Radio
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-531:
--------------------------------
Fix Version/s: 1.3.0-beta2
Priority: Minor (was: Major)
I agree this is an issue. I've updated the FormComponentLabel to accept Radio and Check components as constructor params. (Fix is in r545949.)
> FormComponentLabel and Radio
> ----------------------------
>
> Key: WICKET-531
> URL: https://issues.apache.org/jira/browse/WICKET-531
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: any
> Reporter: Jan Kriesten
> Assignee: Alastair Maw
> Priority: Minor
> Fix For: 1.3.0-beta2
>
>
> Since Radio extends WebMarkupContainer instead of FormComponent, it's not possible to set FormComponentLabels for Radio-buttons.
> Since it's desireable to be able to click on the label to select a radio-button, it would be nice to change this to reflect that Radio really is a FormComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-531) FormComponentLabel and Radio
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-531:
--------------------------------
Fix Version/s: (was: 1.3.0-beta2)
1.3.0-beta3
> FormComponentLabel and Radio
> ----------------------------
>
> Key: WICKET-531
> URL: https://issues.apache.org/jira/browse/WICKET-531
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: any
> Reporter: Jan Kriesten
> Assignee: Alastair Maw
> Priority: Minor
> Fix For: 1.3.0-beta3
>
>
> Since Radio extends WebMarkupContainer instead of FormComponent, it's not possible to set FormComponentLabels for Radio-buttons.
> Since it's desireable to be able to click on the label to select a radio-button, it would be nice to change this to reflect that Radio really is a FormComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-531) FormComponentLabel and Radio
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw resolved WICKET-531.
---------------------------------
Resolution: Fixed
> FormComponentLabel and Radio
> ----------------------------
>
> Key: WICKET-531
> URL: https://issues.apache.org/jira/browse/WICKET-531
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: any
> Reporter: Jan Kriesten
> Assignee: Alastair Maw
> Priority: Minor
> Fix For: 1.3.0-beta2
>
>
> Since Radio extends WebMarkupContainer instead of FormComponent, it's not possible to set FormComponentLabels for Radio-buttons.
> Since it's desireable to be able to click on the label to select a radio-button, it would be nice to change this to reflect that Radio really is a FormComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-531) FormComponentLabel and Radio
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw resolved WICKET-531.
---------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.3.0-beta3)
1.3.0-beta2
You can't just make Radio and Check FormComponents, because the validation, required checks, etc don't really apply to them.
This is now fixed by abstracting out the label stuff into ILabelProvider and LabeledWebMarkupContainer, which Radio, Check and FormComponent now all extend. Your use case should work. (Fix is in r548197.)
> FormComponentLabel and Radio
> ----------------------------
>
> Key: WICKET-531
> URL: https://issues.apache.org/jira/browse/WICKET-531
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: any
> Reporter: Jan Kriesten
> Assignee: Alastair Maw
> Priority: Minor
> Fix For: 1.3.0-beta2
>
>
> Since Radio extends WebMarkupContainer instead of FormComponent, it's not possible to set FormComponentLabels for Radio-buttons.
> Since it's desireable to be able to click on the label to select a radio-button, it would be nice to change this to reflect that Radio really is a FormComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-531) FormComponentLabel and Radio
Posted by "Jan Kriesten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Kriesten reopened WICKET-531:
---------------------------------
The fix doesn't address handling consistency between form components (as Radio and Checkbox should behave imho).
Also, this way you can't set the Label, which leeds to FormComponentLabel only returns "RadioLabel" as label string for the Radio button!
This should be working:
Radio radio = new Radio( "radioelement", new Model( value ) );
radio.setLabel( new Model( label ) );
SimpleFormComponentLabel radiolabel = new SimpleFormComponentLabel( "radiolabel", radio );
Regards, --- Jan.
> FormComponentLabel and Radio
> ----------------------------
>
> Key: WICKET-531
> URL: https://issues.apache.org/jira/browse/WICKET-531
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: any
> Reporter: Jan Kriesten
> Assignee: Alastair Maw
> Priority: Minor
> Fix For: 1.3.0-beta2
>
>
> Since Radio extends WebMarkupContainer instead of FormComponent, it's not possible to set FormComponentLabels for Radio-buttons.
> Since it's desireable to be able to click on the label to select a radio-button, it would be nice to change this to reflect that Radio really is a FormComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-531) FormComponentLabel and Radio
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw reassigned WICKET-531:
-----------------------------------
Assignee: Alastair Maw
> FormComponentLabel and Radio
> ----------------------------
>
> Key: WICKET-531
> URL: https://issues.apache.org/jira/browse/WICKET-531
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: any
> Reporter: Jan Kriesten
> Assignee: Alastair Maw
>
> Since Radio extends WebMarkupContainer instead of FormComponent, it's not possible to set FormComponentLabels for Radio-buttons.
> Since it's desireable to be able to click on the label to select a radio-button, it would be nice to change this to reflect that Radio really is a FormComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.