[GitHub] [royale-asjs] carlosrovira commented on pull request #1077: New bead BadgeWithMouseClick

[GitBox <gi...@apache.org>]

carlosrovira commented on pull request #1077:
URL: https://github.com/apache/royale-asjs/pull/1077#issuecomment-775092373


   Hi Maria Jose, 
   thanks for the contribution. About the bead commit, I see it completely right.
   About the examples, I see examples I see various things:
   - hardcoded styles. In this case the bead just add a click behavior. So don't understand the need of all the styles added to TDJ. Think that TDJ has already considerable weight, and we need to keep in diet as much as we can.
   - Also I see examples in Button and Combo pages and additional renderer. Although is very valuable, I think the example should be just add the bead to one of the Badges already in place in the footer to show how it works.
   
   I think is good to separate the commits to help the review, but for next PRs, can you separate "by functionality", I mean. One PR for the framework bead and other for the examples? In the current way, it helps review, but since the first is ok but the later not, I still can't merge it.
   
   Thanks again for sharing the code! :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org