You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/12/06 13:15:34 UTC

[GitHub] [zookeeper] KimRasak commented on issue #1167: Fix haveDelivered wrong implementation.

KimRasak commented on issue #1167: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1167#issuecomment-562567026
 
 
   I still think there's sth wrong with the `QuorumCnxManager.haveDelivered()`or 
   ```
   if(manager.haveDelivered()){
     sendNotifications();
   } else {
     manager.connectAll();
   }
   ```
   **Becase the old implementation won't try to "connect all" as long as the first "sending queue" is empty**.
   But I don't know how to simulate the scene.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services