[jira] [Commented] (SLING-2920) Wrong handling of Sling Filter ordering

["Olaf Otto (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574410#comment-14574410 ] 

Olaf Otto commented on SLING-2920:
----------------------------------

I am afraid the change is a bigger issue then it may seem. It means that anyone upgrading to this version - AEM 6.1 users, in particular - will very likely experience issues. Moreover, code may have to be changed that is not under the control of the users. For instance, our customers are using feature packages provided by Adobe, the OSS community and various vendors, all of which would have to provide updated versions.

I would thus strongly suggest to revert this change and provide a fix package to the upgrading users.



> Wrong handling of Sling Filter ordering
> ---------------------------------------
>
>                 Key: SLING-2920
>                 URL: https://issues.apache.org/jira/browse/SLING-2920
>             Project: Sling
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: Engine 2.2.8
>            Reporter: Felix Meschberger
>            Assignee: Carsten Ziegeler
>             Fix For: Engine 2.3.4
>
>         Attachments: SLING-2920.patch
>
>
> It looks like the ordering of Sling Filters is not implemented as it is documented on [1].
> The documented intent is:
> * service.ranking ordering with higher numbers being higher preference over lower numbers
> * filter.order ordering with lower numbers being higher preference over higher numbers
> * filter.order is ignored if service.ranking is defined
> * higher preferenced filters called before lower preferenced filters
> Actual implementation:
> * service.ranking ordering with lower numbers being higher preference over higher numbers
> * filter.order ordering with lower numbers being higher preference over higher numbers
> * filter.order is ignored if service.ranking is defined
> * higher preferenced filters called before lower preferenced filters
> As one can see, the service.ranking ordering is not properly implemented. It looks like this has been wrong since the first implementation as of SLING-1735 (Jan 2011).
> We can either live with this actual implementation and fix the documentation or fix the implementation at the cost of having to also fix any down-stream filter providers using service.ranking values as implemented (and not as documented).
> Discussion at http://sling.markmail.org/thread/h6uiveb2udw6y46q
> [1] http://sling.apache.org/documentation/the-sling-engine/filters.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)