You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2017/05/04 07:13:59 UTC
[GitHub] flink pull request #3820: [FLINK-6381] [connector] Unnecessary synchronizing...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3820
[FLINK-6381] [connector] Unnecessary synchronizing object in Bucketin…
Currently there are two places should not employ the synchronized to describe ```pendingFilesPerCheckpoint```, as it is only restored state object for checkpoint and no sharing of the data-structure between different threads
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-6381
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3820.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3820
----
commit ba9be98844d81ddec7cd8aae95457f2e3e3f6acb
Author: zhangminglei <zm...@163.com>
Date: 2017-05-04T07:11:20Z
[FLINK-6381] [connector] Unnecessary synchronizing object in BucketingSink.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3820: [FLINK-6381] [connector] Unnecessary synchronizing object...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3820
Hi @zhangminglei ! I will have a look during this week. Sorry for the delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3820: [FLINK-6381] [connector] Unnecessary synchronizing object...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3820
Thanks for review @kl0u and the travis had gave us the green light. Very appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3820: [FLINK-6381] [connector] Unnecessary synchronizing...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/3820
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3820: [FLINK-6381] [connector] Unnecessary synchronizing object...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3820
@kl0u Okay. I will do this soon. Thanks again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3820: [FLINK-6381] [connector] Unnecessary synchronizing object...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3820
Hi, @kl0u. It would be great if you can take a look at this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3820: [FLINK-6381] [connector] Unnecessary synchronizing object...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3820
Thanks for your work @zhangminglei . Changes look good! Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3820: [FLINK-6381] [connector] Unnecessary synchronizing object...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3820
Merged this. Could you close the PR and the related JIRA?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---