You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/08/06 18:06:13 UTC

[GitHub] mgencur commented on issue #3737: tests package needs some cleanup

mgencur commented on issue #3737: tests package needs some cleanup
URL: https://github.com/apache/incubator-openwhisk/issues/3737#issuecomment-410798821
 
 
   At this point I'd suggest the following changes to the test suite so as to achieve a better logical grouping of the tests:
   1) move tests from system.basic.WskRestBasicTests to respective test classes (in the same package) for Actions, Rules, Packages etc. because the single class is a mix of tests that should be in the specific classes
   2) move some tests from whisk.core.cli.test package to the system.basic package as they're using REST and are system-level tests anyway:
       - WskRestBasicUsageTests - move tests to system.basic.{Action, Package, ...} except for two methods which are related to web actions, move these to whisk.core.cli.test.WskWebActionsTest
       - pull test cases from WskActionSequenceTests and WskRestActionSequenceTests into a system.basic.WskSequenceTests, they're all using REST
       - merge WskEntitlementTests and WskRestEntitlementTests into a single non-abstract class, and move this class to system.basic package
         (it's been more than a year and there's still no other implementation than REST)
       - move BaseApiGwTests, ApiGwRestBasicTests, ApiGwRestTests to a newly created package _system.api_
       - since at this point the only remaining class in whisk.core.cli.test is WskWebActionTests, let's rename the package to _whisk.core.web_

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services