You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/02/12 18:49:00 UTC

[jira] [Updated] (GEODE-6395) Safeguard spotless custom rule bump

     [ https://issues.apache.org/jira/browse/GEODE-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated GEODE-6395:
----------------------------------
    Labels: pull-request-available  (was: )

> Safeguard spotless custom rule bump
> -----------------------------------
>
>                 Key: GEODE-6395
>                 URL: https://issues.apache.org/jira/browse/GEODE-6395
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Patrick Rhomberg
>            Assignee: Patrick Rhomberg
>            Priority: Major
>              Labels: pull-request-available
>
> The Spotless method {{bumpThisNumberIfACustomStepChanges}} should have its input changed whenever a custom rule is changed or added.  Failure to do so can cause spotless to not execute, or to throw an NPE in rare instances.
> Developers can easily overlook this however.  As an alternative, we could pass the sha of the spotless file itself to this method, ensuring that any change to spotless will cause the spotless cache to invalidate itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)