You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2016/09/20 09:26:37 UTC

[GitHub] zeppelin pull request #1444: ZEPPELIN-1456: Flaky Test: AuthenticationIT

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/1444

    ZEPPELIN-1456: Flaky Test: AuthenticationIT

    ### What is this PR for?
    This started happening after ZEPPELIN-1144, https://github.com/apache/zeppelin/pull/1330.
    This test (testGroupPermission) is to validate the group related permission on a notebook.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Fix CI
    
    ### What is the Jira issue?
    * [ZEPPELIN-1456](https://issues.apache.org/jira/browse/ZEPPELIN-1456)
    
    ### How should this be tested?
    CI xxx.10 (selenium) should be green
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? n/a
    * Is there breaking changes for older versions? n/a
    * Does this needs documentation? n/a
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1456

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1444.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1444
    
----
commit e0c5766c2c298dbd3196b9e4d88b68c1ac2e22ee
Author: Prabhjyot Singh <pr...@gmail.com>
Date:   2016-09-20T09:23:08Z

    ZEPPELIN-1456: fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1444: ZEPPELIN-1456: Flaky Test: AuthenticationIT

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1444
  
    CI failure on this PR is irrelevant and failing on only build profile.
    We might want to open a JIRA issue for it, because that build profile normally have `-DskipTest`
    But seems to fail on a test.
    
    Merging this one quickly to have other PR's CI green


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1444: ZEPPELIN-1456: Flaky Test: AuthenticationIT

Posted by khalidhuseynov <gi...@git.apache.org>.

Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/1444
  
    makes sense, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1444: ZEPPELIN-1456: Flaky Test: AuthenticationIT

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1444
  
    Thank you @corneadoug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1444: ZEPPELIN-1456: Flaky Test: AuthenticationIT

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1444
  
    Thanks @prabhjyotsingh!
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1444: ZEPPELIN-1456: Flaky Test: AuthenticationIT

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1444


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---