You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/05/02 22:16:51 UTC
[GitHub] [helix] micahstubbs opened a new pull request, #2077: remove missing helix-front tslint linting rules to fix warnings
micahstubbs opened a new pull request, #2077:
URL: https://github.com/apache/helix/pull/2077
### Description
This PR removes helix-front tslint linting rules that are missing implementations to fix warnings when running `npm run lint`.
### Issues
fix #2076
### Tests
```
npm run lint
> helix-front@1.2.1 lint /Users/m/workspace/helix/helix-front
> ng lint
All files pass linting.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on pull request #2077: remove missing helix-front tslint linting rules to fix warnings
Posted by GitBox <gi...@apache.org>.
junkaixue commented on PR #2077:
URL: https://github.com/apache/helix/pull/2077#issuecomment-1126347444
Please follow: https://github.com/apache/helix/wiki/Pull-Request-Merge-Steps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2077: remove missing helix-front tslint linting rules to fix warnings
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2077:
URL: https://github.com/apache/helix/pull/2077#issuecomment-1115456325
@qqu0127 good questions.
The rules `no-access-missing-member`,
`templates-use-public` [were removed from codelyzer](https://github.com/mgechev/codelyzer/issues/488) sometime before January 2018. Reading the comments from that issue, it does not appear that there are equivalent replacement rules for these two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on pull request #2077: remove missing helix-front tslint linting rules to fix warnings
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on PR #2077:
URL: https://github.com/apache/helix/pull/2077#issuecomment-1115445710
Thank you Micah for the fix. Just curious, are these rules removed in the new angular and codelyzer version? And do they provide any equivalent lint solutions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2077: remove missing helix-front tslint linting rules to fix warnings
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2077:
URL: https://github.com/apache/helix/pull/2077#issuecomment-1115457301
@qqu0127 `invoke-injectable` was a rule made redundant by TypeScript sometime before March 2017. https://github.com/mgechev/codelyzer/issues/260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] somecodemonkey commented on pull request #2077: remove missing helix-front tslint linting rules to fix warnings
Posted by GitBox <gi...@apache.org>.
somecodemonkey commented on PR #2077:
URL: https://github.com/apache/helix/pull/2077#issuecomment-1125350825
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #2077: remove missing helix-front tslint linting rules to fix warnings
Posted by GitBox <gi...@apache.org>.
junkaixue merged PR #2077:
URL: https://github.com/apache/helix/pull/2077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2077: remove missing helix-front tslint linting rules to fix warnings
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2077:
URL: https://github.com/apache/helix/pull/2077#issuecomment-1126358092
"This PR is ready to be merged."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2077: remove missing helix-front tslint linting rules to fix warnings
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2077:
URL: https://github.com/apache/helix/pull/2077#issuecomment-1115580709
Thanks for the review @qqu0127 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org