Change in asterixdb[master]: Hyracks Unit tests for LSM Filters

["Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>]

Ian Maxon has posted comments on this change.

Change subject: Hyracks Unit tests for LSM Filters
......................................................................


Patch Set 10:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1704/10/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/common/TreeIndexTestUtils.java
File hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/common/TreeIndexTestUtils.java:

PS10, Line 91:         
> If it's filtered, why do we deduct 1?
If there is a filter there will be one more field at the end, but it needs to be handled separately. Hence you stop right before the end if that is the case, and then handle it afterwards.


https://asterix-gerrit.ics.uci.edu/#/c/1704/10/hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeFilterMergeTest.java
File hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeFilterMergeTest.java:

Line 32: 
> Can you put a comment here in Java-doc style? What does this do?
As I expressed in the previous comment, I think it would be a bit repetitive to put a comment here when the purpose of this class is more plainly seen in the ancestor class. I can if you really want me to, but honestly this class is just parameter setting, it doesn't have much else in it.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1704
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <ji...@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wa...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes