You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "anthonychengit (via GitHub)" <gi...@apache.org> on 2026/07/19 06:46:30 UTC
[PR] test(frontend): cover workflow broken check [texera]
anthonychengit opened a new pull request, #6547:
URL: https://github.com/apache/texera/pull/6547
### What changes were proposed in this PR?
This PR adds unit-test coverage for `checkIfWorkflowBroken`.
Covered behavior:
- returns `false` when every link references existing operators;
- returns `true` when a link source references a missing operator;
- returns `true` when a link target references a missing operator;
- returns `false` when the workflow has no links.
### Any related issues, documentation, discussions?
Closes #6258
### How was this PR tested?
Tested with:
- `node .yarn/releases/yarn-4.14.1.cjs prettier --check src/app/common/util/workflow-check.spec.ts`
- `node .yarn/releases/yarn-4.14.1.cjs eslint src/app/common/util/workflow-check.spec.ts`
- `node .yarn/releases/yarn-4.14.1.cjs test --include=src/app/common/util/workflow-check.spec.ts`
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex was used for implementation and verification assistance. I reviewed the final code and test output before submission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover workflow broken check [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6547:
URL: https://github.com/apache/texera/pull/6547#issuecomment-5014749971
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover workflow broken check [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #6547:
URL: https://github.com/apache/texera/pull/6547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover workflow broken check [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6547:
URL: https://github.com/apache/texera/pull/6547#issuecomment-5014770875
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6547?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 72.53%. Comparing base ([`80c45be`](https://app.codecov.io/gh/apache/texera/commit/80c45be89dbbc64abafe0f70a1c05ef7117fbaa8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ca589ff`](https://app.codecov.io/gh/apache/texera/commit/ca589ff9eb2ca361529643ad652ea574c2cb3317?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6547 +/- ##
============================================
- Coverage 72.54% 72.53% -0.02%
Complexity 3436 3436
============================================
Files 1145 1145
Lines 45129 45129
Branches 4975 4975
============================================
- Hits 32738 32733 -5
- Misses 10709 10710 +1
- Partials 1682 1686 +4
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6547/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [80c45be](https://app.codecov.io/gh/apache/texera/commit/80c45be89dbbc64abafe0f70a1c05ef7117fbaa8?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.76% <ø> (ø)` | | Carriedforward from [80c45be](https://app.codecov.io/gh/apache/texera/commit/80c45be89dbbc64abafe0f70a1c05ef7117fbaa8?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.81% <ø> (ø)` | | Carriedforward from [80c45be](https://app.codecov.io/gh/apache/texera/commit/80c45be89dbbc64abafe0f70a1c05ef7117fbaa8?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `17.72% <ø> (ø)` | | Carriedforward from [80c45be](https://app.codecov.io/gh/apache/texera/commit/80c45be89dbbc64abafe0f70a1c05ef7117fbaa8?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.66% <ø> (ø)` | | Carriedforward from [80c45be](https://app.codecov.io/gh/apache/texera/commit/80c45be89dbbc64abafe0f70a1c05ef7117fbaa8?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.80% <ø> (ø)` | | Carriedforward from [80c45be](https://app.codecov.io/gh/apache/texera/commit/80c45be89dbbc64abafe0f70a1c05ef7117fbaa8?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.78% <ø> (-0.02%)` | :arrow_down: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.94% <ø> (ø)` | | Carriedforward from [80c45be](https://app.codecov.io/gh/apache/texera/commit/80c45be89dbbc64abafe0f70a1c05ef7117fbaa8?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.79% <ø> (ø)` | | Carriedforward from [80c45be](https://app.codecov.io/gh/apache/texera/commit/80c45be89dbbc64abafe0f70a1c05ef7117fbaa8?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [80c45be](https://app.codecov.io/gh/apache/texera/commit/80c45be89dbbc64abafe0f70a1c05ef7117fbaa8?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6547?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover workflow broken check [texera]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #6547:
URL: https://github.com/apache/texera/pull/6547#discussion_r3611610348
##########
frontend/src/app/common/util/workflow-check.spec.ts:
##########
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { checkIfWorkflowBroken } from "./workflow-check";
+
+type WorkflowInput = Parameters<typeof checkIfWorkflowBroken>[0];
+
+function createWorkflow(
+ operatorIDs: ReadonlyArray<string>,
+ links: ReadonlyArray<{
+ sourceOperatorID: string;
+ targetOperatorID: string;
+ }>
+): WorkflowInput {
+ return {
+ content: {
+ operators: operatorIDs.map(operatorID => ({ operatorID })),
+ links: links.map(({ sourceOperatorID, targetOperatorID }) => ({
+ source: { operatorID: sourceOperatorID },
+ target: { operatorID: targetOperatorID },
+ })),
+ },
+ } as unknown as WorkflowInput;
+}
Review Comment:
Optional: avoid `as unknown as WorkflowInput` in this test helper—using an unsafe double-cast bypasses type-checking and can let the test drift from the real `Workflow`/`WorkflowContent` shape. Since `WorkflowMetadata` and `WorkflowContent` have manageable required fields, you can build a minimal but fully-typed workflow object (with stub operator/link fields) and remove the cast entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org