You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by kiszk <gi...@git.apache.org> on 2017/10/06 15:10:56 UTC

[GitHub] spark pull request #19082: [SPARK-21870][SQL] Split aggregation code into sm...

Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19082#discussion_r143216395
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ---
    @@ -944,6 +945,24 @@ class CodegenContext {
       }
     }
     
    +object CodegenContext {
    +
    +  private val javaKeywords = Set(
    --- End diff --
    
    Do we need add `enum`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org