You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/03/15 06:20:15 UTC
[GitHub] [cordova-ios] dpogue commented on a change in pull request #543:
GH-542 Adding Podspec for Cordova library
dpogue commented on a change in pull request #543: GH-542 Adding Podspec for Cordova library
URL: https://github.com/apache/cordova-ios/pull/543#discussion_r265860518
##########
File path: Cordova.podspec
##########
@@ -0,0 +1,32 @@
+Pod::Spec.new do |s|
+ s.name = "Cordova"
+ s.version = "5.1.0"
Review comment:
It looks like parsing package.json might be possible, based on what I see in the Podspec for React Native: https://github.com/facebook/react-native/blob/d0d8c8b651af6a2883307c777a1dfb753f046f7c/React.podspec#L7-L10
This would be preferable, since it's one less spot that could get missed during version bumps. The version in package.json **must** be correct, so it's safest to use that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org