You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/07/16 15:34:36 UTC

[GitHub] [geode-benchmarks] Bill commented on a change in pull request #130: Enable geode-benchmarks to run with only servers

Bill commented on a change in pull request #130:
URL: https://github.com/apache/geode-benchmarks/pull/130#discussion_r455878798



##########
File path: geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/GeodeBenchmark.java
##########
@@ -45,11 +46,20 @@ public static TestConfig createConfig() {
     config.durationSeconds(BENCHMARK_DURATION);
     config.threads(THREADS);
 
-    final String sniProp = System.getProperty("withSniProxy");
-    final boolean doSni = sniProp != null && !sniProp.equals("false");
+    String prop = System.getProperty("withSniProxy");

Review comment:
       I simply didn't know about `getBoolean()`. `GeodeProperties.isPropertySet(String)` can be replaced with `getBoolean()` too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org