[GitHub] [superset] junlincc commented on a change in pull request #12773: chore: Tab title to be empty when creating a new tab

[GitBox <gi...@apache.org>]

junlincc commented on a change in pull request #12773:
URL: https://github.com/apache/superset/pull/12773#discussion_r574156567



##########
File path: superset-frontend/src/components/EditableTitle.tsx
##########
@@ -23,28 +23,33 @@ import TooltipWrapper from './TooltipWrapper';
 
 interface EditableTitleProps {
   canEdit?: boolean;
+  editing?: boolean;
   emptyText?: string;
   extraClasses?: Array<string> | string;
   multiLine?: boolean;
   noPermitTooltip?: string;
   onSaveTitle: (arg0: string) => {};
   showTooltip?: boolean;
   style?: object;
-  title: string;
+  title?: string;
+  defaultTitle?: string;
+  placeholder?: string;
 }
 
 export default function EditableTitle({
   canEdit = false,
-  emptyText,
+  editing = false,
   extraClasses,
   multiLine = false,
   noPermitTooltip,
   onSaveTitle,
   showTooltip = true,
   style,
-  title,
+  title = '',
+  defaultTitle = '',
+  placeholder = '',

Review comment:
       they serve the same purpose right from the UI? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org