You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2017/08/18 01:30:54 UTC
Review Request 61725: Added secrets docs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61725/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff.
Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418
Repository: mesos
Description
-------
Added secrets docs.
Diffs
-----
docs/secrets.md PRE-CREATION
Diff: https://reviews.apache.org/r/61725/diff/1/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 61725: Added secrets docs.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61725/#review183243
-----------------------------------------------------------
Bad patch!
Reviews applied: [61725]
Failed command: python support/apply-reviews.py -n -r 61725
Error:
error: patch failed: docs/home.md:35
error: docs/home.md: patch does not apply
error: docs/secrets.md: already exists in index
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/252/console
- Mesos Reviewbot Windows
On Aug. 18, 2017, 1:29 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61725/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 1:29 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added secrets docs.
>
>
> Diffs
> -----
>
> docs/home.md ab32838f621de76498262c9dd04e1cf01f8378ca
> docs/secrets.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61725/diff/4/
>
>
> Testing
> -------
>
> ./mesos-website-dev.sh
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 61725: Added secrets docs.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61725/
-----------------------------------------------------------
(Updated Aug. 18, 2017, 1:29 p.m.)
Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff.
Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418
Repository: mesos
Description
-------
Added secrets docs.
Diffs
-----
docs/home.md ab32838f621de76498262c9dd04e1cf01f8378ca
docs/secrets.md PRE-CREATION
Diff: https://reviews.apache.org/r/61725/diff/4/
Testing
-------
./mesos-website-dev.sh
Thanks,
Kapil Arya
Re: Review Request 61725: Added secrets docs.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61725/#review183226
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61731, 61732, 61733, 61725]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 18, 2017, 11:46 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61725/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 11:46 a.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added secrets docs.
>
>
> Diffs
> -----
>
> docs/home.md ab32838f621de76498262c9dd04e1cf01f8378ca
> docs/secrets.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61725/diff/4/
>
>
> Testing
> -------
>
> ./mesos-website-dev.sh
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 61725: Added secrets docs.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61725/
-----------------------------------------------------------
(Updated Aug. 18, 2017, 11:46 a.m.)
Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff.
Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418
Repository: mesos
Description
-------
Added secrets docs.
Diffs
-----
docs/home.md ab32838f621de76498262c9dd04e1cf01f8378ca
docs/secrets.md PRE-CREATION
Diff: https://reviews.apache.org/r/61725/diff/4/
Testing (updated)
-------
./mesos-website-dev.sh
Thanks,
Kapil Arya
Re: Review Request 61725: Added secrets docs.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61725/
-----------------------------------------------------------
(Updated Aug. 18, 2017, 11:45 a.m.)
Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff.
Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418
Repository: mesos
Description
-------
Added secrets docs.
Diffs (updated)
-----
docs/home.md ab32838f621de76498262c9dd04e1cf01f8378ca
docs/secrets.md PRE-CREATION
Diff: https://reviews.apache.org/r/61725/diff/4/
Changes: https://reviews.apache.org/r/61725/diff/3-4/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 61725: Added secrets docs.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61725/#review183218
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61731, 61732, 61733, 61725]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 18, 2017, 2:18 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61725/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 2:18 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added secrets docs.
>
>
> Diffs
> -----
>
> docs/home.md ab32838f621de76498262c9dd04e1cf01f8378ca
> docs/secrets.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61725/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 61725: Added secrets docs.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61725/
-----------------------------------------------------------
(Updated Aug. 18, 2017, 10:18 a.m.)
Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff.
Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418
Repository: mesos
Description
-------
Added secrets docs.
Diffs (updated)
-----
docs/home.md ab32838f621de76498262c9dd04e1cf01f8378ca
docs/secrets.md PRE-CREATION
Diff: https://reviews.apache.org/r/61725/diff/3/
Changes: https://reviews.apache.org/r/61725/diff/2-3/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 61725: Added secrets docs.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61725/
-----------------------------------------------------------
(Updated Aug. 18, 2017, 10 a.m.)
Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff.
Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418
Repository: mesos
Description
-------
Added secrets docs.
Diffs (updated)
-----
docs/secrets.md PRE-CREATION
Diff: https://reviews.apache.org/r/61725/diff/2/
Changes: https://reviews.apache.org/r/61725/diff/1-2/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 61725: Added secrets docs.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61725/#review183207
-----------------------------------------------------------
Fix it, then Ship it!
Great to see this being documented - thanks so much Kapil!
We may want to be a bit more explicit when it comes to tha lack of Secrets within the docker containerizer. Couple of possibly entirely incorrect wording suggestions - sorry if they are BS as I am not a native speaker.
docs/secrets.md
Lines 7 (patched)
<https://reviews.apache.org/r/61725/#comment259221>
s/now// ?
docs/secrets.md
Lines 9 (patched)
<https://reviews.apache.org/r/61725/#comment259222>
s/one to specify/specifying ?
docs/secrets.md
Lines 11 (patched)
<https://reviews.apache.org/r/61725/#comment259223>
Isn't the UCR just a name for the Mesos containerizer using (docker) base images - I am not sure this won't confuse people. Also note that our docs do not mention "UCR" at all.
Maybe be explicit here; "... and not the docker containerizer"?
docs/secrets.md
Lines 14 (patched)
<https://reviews.apache.org/r/61725/#comment259224>
Maybe:
"Secrets can be specified using the following protobuf messages." ?
docs/secrets.md
Lines 41 (patched)
<https://reviews.apache.org/r/61725/#comment259225>
You are introducing "modules" here which may be a bit confusing. How about mentioning modules in the high level description already? Something that tells the user that a secret resolver would be commonly implemented using modules?
docs/secrets.md
Lines 111 (patched)
<https://reviews.apache.org/r/61725/#comment259226>
Maybe we should be explicit again and tell users that we do NOT mean docker containerizer here but docker containers handled by the mesos containerizer? By saying only docker containers, which ones are we not supporting - can we name them here?
docs/secrets.md
Lines 142 (patched)
<https://reviews.apache.org/r/61725/#comment259227>
s/A default/The default/?
s/resolved/resolvs/?
- Till Toenshoff
On Aug. 18, 2017, 1:30 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61725/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 1:30 a.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added secrets docs.
>
>
> Diffs
> -----
>
> docs/secrets.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61725/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 61725: Added secrets docs.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61725/#review183192
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61725]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 18, 2017, 1:30 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61725/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 1:30 a.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added secrets docs.
>
>
> Diffs
> -----
>
> docs/secrets.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61725/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>