You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/22 06:46:13 UTC
[GitHub] [airflow] varunvora opened a new pull request #13826: Fix DAGs mount path in Kubernetes worker pod when gitSync is enabled
varunvora opened a new pull request #13826:
URL: https://github.com/apache/airflow/pull/13826
closes: #13680
The path to search for DAGs is incorrect in the new pod when gitSync is enabled. The error it causes currently is mentioned int the issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dnskr commented on pull request #13826: Fix DAGs mount path in Kubernetes worker pod when gitSync is enabled
Posted by GitBox <gi...@apache.org>.
dnskr commented on pull request #13826:
URL: https://github.com/apache/airflow/pull/13826#issuecomment-769223898
Hi @varunvora!
Please have a look this change: https://github.com/varunvora/airflow/pull/1#issue-563399608
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #13826: Fix DAGs mount path in Kubernetes worker pod when gitSync is enabled
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #13826:
URL: https://github.com/apache/airflow/pull/13826
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dnskr edited a comment on pull request #13826: Fix DAGs mount path in Kubernetes worker pod when gitSync is enabled
Posted by GitBox <gi...@apache.org>.
dnskr edited a comment on pull request #13826:
URL: https://github.com/apache/airflow/pull/13826#issuecomment-769223898
Hi @varunvora!
Please have a look this change: https://github.com/varunvora/airflow/pull/1#issue-563399608
Actually we have two reasons of the [13680](https://github.com/apache/airflow/issues/13680) issue. Your fix + mine fix solved both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13826: Fix DAGs mount path in Kubernetes worker pod when gitSync is enabled
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13826:
URL: https://github.com/apache/airflow/pull/13826#issuecomment-773534945
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #13826: Fix DAGs mount path in Kubernetes worker pod when gitSync is enabled
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #13826:
URL: https://github.com/apache/airflow/pull/13826
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13826: Fix DAGs mount path in Kubernetes worker pod when gitSync is enabled
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13826:
URL: https://github.com/apache/airflow/pull/13826#issuecomment-765174832
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] varunvora commented on pull request #13826: Fix DAGs mount path in Kubernetes worker pod when gitSync is enabled
Posted by GitBox <gi...@apache.org>.
varunvora commented on pull request #13826:
URL: https://github.com/apache/airflow/pull/13826#issuecomment-769285373
@potiuk can you review this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13826: Fix DAGs mount path in Kubernetes worker pod when gitSync is enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13826:
URL: https://github.com/apache/airflow/pull/13826#issuecomment-765194742
[The Workflow run](https://github.com/apache/airflow/actions/runs/503029886) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13826: Fix DAGs mount path in Kubernetes worker pod when gitSync is enabled
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13826:
URL: https://github.com/apache/airflow/pull/13826#issuecomment-773534945
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org