You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Mukarram Baig (JIRA)" <ji...@apache.org> on 2011/07/20 17:02:57 UTC
[jira] [Created] (WW-3664) FileUpload interceptor not recursively
creating directories if one doesn't already exist
FileUpload interceptor not recursively creating directories if one doesn't already exist
----------------------------------------------------------------------------------------
Key: WW-3664
URL: https://issues.apache.org/jira/browse/WW-3664
Project: Struts 2
Issue Type: Bug
Components: Dispatch Filter
Affects Versions: 2.2.1
Environment: Solaris
Reporter: Mukarram Baig
The current implementation of the file upload interceptor, if the multipart save directory location specified does not already exist, we try to create it but not recursively. Is there a reason for not doing it? More specifically, we are calling multipartSaveDir.mkdir() rather than multipartSaveDir.mkdirs(). I can attach a patch if that helps...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WW-3664) FileUpload interceptor not recursively
creating directories if one doesn't already exist
Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart updated WW-3664:
------------------------------
Fix Version/s: (was: 2.3.x)
2.3.6
> FileUpload interceptor not recursively creating directories if one doesn't already exist
> ----------------------------------------------------------------------------------------
>
> Key: WW-3664
> URL: https://issues.apache.org/jira/browse/WW-3664
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Interceptors
> Affects Versions: 2.2.1
> Environment: Solaris
> Reporter: Mukarram Baig
> Priority: Trivial
> Fix For: 2.3.6
>
> Attachments: WW-3364.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current implementation of the file upload interceptor, if the multipart save directory location specified does not already exist, we try to create it but not recursively. Is there a reason for not doing it? More specifically, we are calling multipartSaveDir.mkdir() rather than multipartSaveDir.mkdirs(). I can attach a patch if that helps...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WW-3664) FileUpload interceptor not recursively
creating directories if one doesn't already exist
Posted by "Mukarram Baig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mukarram Baig updated WW-3664:
------------------------------
Attachment: WW-3364.patch
Change to Dispatcher.java that will create the directory tree
> FileUpload interceptor not recursively creating directories if one doesn't already exist
> ----------------------------------------------------------------------------------------
>
> Key: WW-3664
> URL: https://issues.apache.org/jira/browse/WW-3664
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Interceptors
> Affects Versions: 2.2.1
> Environment: Solaris
> Reporter: Mukarram Baig
> Priority: Trivial
> Attachments: WW-3364.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current implementation of the file upload interceptor, if the multipart save directory location specified does not already exist, we try to create it but not recursively. Is there a reason for not doing it? More specifically, we are calling multipartSaveDir.mkdir() rather than multipartSaveDir.mkdirs(). I can attach a patch if that helps...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3664) FileUpload interceptor not recursively
creating directories if one doesn't already exist
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068524#comment-13068524 ]
Dave Newton commented on WW-3664:
---------------------------------
I think he's just saying that the current code will make a directory, he wants it to make the entire tree.
I'm changing the priority to low.
> FileUpload interceptor not recursively creating directories if one doesn't already exist
> ----------------------------------------------------------------------------------------
>
> Key: WW-3664
> URL: https://issues.apache.org/jira/browse/WW-3664
> Project: Struts 2
> Issue Type: Bug
> Components: Dispatch Filter
> Affects Versions: 2.2.1
> Environment: Solaris
> Reporter: Mukarram Baig
> Labels: features
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current implementation of the file upload interceptor, if the multipart save directory location specified does not already exist, we try to create it but not recursively. Is there a reason for not doing it? More specifically, we are calling multipartSaveDir.mkdir() rather than multipartSaveDir.mkdirs(). I can attach a patch if that helps...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WW-3664) FileUpload interceptor not recursively
creating directories if one doesn't already exist
Posted by "Lukasz Lenart (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart updated WW-3664:
------------------------------
Fix Version/s: 2.3.x
> FileUpload interceptor not recursively creating directories if one doesn't already exist
> ----------------------------------------------------------------------------------------
>
> Key: WW-3664
> URL: https://issues.apache.org/jira/browse/WW-3664
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Interceptors
> Affects Versions: 2.2.1
> Environment: Solaris
> Reporter: Mukarram Baig
> Priority: Trivial
> Fix For: 2.3.x
>
> Attachments: WW-3364.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current implementation of the file upload interceptor, if the multipart save directory location specified does not already exist, we try to create it but not recursively. Is there a reason for not doing it? More specifically, we are calling multipartSaveDir.mkdir() rather than multipartSaveDir.mkdirs(). I can attach a patch if that helps...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3664) FileUpload interceptor not recursively
creating directories if one doesn't already exist
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068515#comment-13068515 ]
Maurizio Cucchiara commented on WW-3664:
----------------------------------------
A patch is always welcome! furthermore a patch is probably the best way to express your idea (that to be honest, I didn't understand :)).
> FileUpload interceptor not recursively creating directories if one doesn't already exist
> ----------------------------------------------------------------------------------------
>
> Key: WW-3664
> URL: https://issues.apache.org/jira/browse/WW-3664
> Project: Struts 2
> Issue Type: Bug
> Components: Dispatch Filter
> Affects Versions: 2.2.1
> Environment: Solaris
> Reporter: Mukarram Baig
> Labels: features
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current implementation of the file upload interceptor, if the multipart save directory location specified does not already exist, we try to create it but not recursively. Is there a reason for not doing it? More specifically, we are calling multipartSaveDir.mkdir() rather than multipartSaveDir.mkdirs(). I can attach a patch if that helps...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WW-3664) FileUpload interceptor not recursively
creating directories if one doesn't already exist
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Newton updated WW-3664:
----------------------------
Component/s: (was: Dispatch Filter)
Core Interceptors
Priority: Trivial (was: Major)
Labels: (was: features)
Issue Type: Improvement (was: Bug)
Made priority/etc. correct.
> FileUpload interceptor not recursively creating directories if one doesn't already exist
> ----------------------------------------------------------------------------------------
>
> Key: WW-3664
> URL: https://issues.apache.org/jira/browse/WW-3664
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Interceptors
> Affects Versions: 2.2.1
> Environment: Solaris
> Reporter: Mukarram Baig
> Priority: Trivial
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current implementation of the file upload interceptor, if the multipart save directory location specified does not already exist, we try to create it but not recursively. Is there a reason for not doing it? More specifically, we are calling multipartSaveDir.mkdir() rather than multipartSaveDir.mkdirs(). I can attach a patch if that helps...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira