[GitHub] [cordova-js] raphinesse opened a new pull request #195: Integrate unused CommonJS tests where applicable

[GitBox <gi...@apache.org>]

raphinesse opened a new pull request #195: Integrate unused CommonJS tests where applicable
URL: https://github.com/apache/cordova-js/pull/195
 
 
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   There has been an unused copy of [The Official Specs for CommonJS][1] lying around in our repository for who knows how long. They needed to be built using a python script and then manually executed in a browser.
   
   This commit integrates all of those tests that also apply to our module system into our existing test suite for `require` & `define`.
   
   [1]: https://github.com/commonjs/commonjs
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Adds adapted versions of the following CommonJs tests to our `test.require.js`:
   
       absolute, transitive, determinism, method, nested, hasOwnProperty
   
   The hasOwnProperty test actually uncovered a bug in our module system implementation and thus is deactivated right now.
   
   The following CommonJS tests were not applicable to Cordova's module system since it does not support cyclic dependencies at all:
   
       cyclic, monkeys
   
   The following CommonJS tests were already covered by tests in `test.require.js`:
   
   - missing: covered by Test#005
   - relative: covered by Test#012
   - exactExports: covered by multiple tests
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org