You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:34:01 UTC

[GitHub] [storm] Ethanlm commented on a change in pull request #3401: STORM-3780 switch ErrorReportingMetrics to V2 API

Ethanlm commented on a change in pull request #3401:
URL: https://github.com/apache/storm/pull/3401#discussion_r668236721



##########
File path: storm-client/src/jvm/org/apache/storm/executor/Executor.java
##########
@@ -680,4 +677,8 @@ public HashMap getSharedExecutorData() {
     public void setLocalExecutorTransfer(ExecutorTransfer executorTransfer) {
         this.executorTransfer = executorTransfer;
     }
+
+    public void incrementErrorCount() {

Review comment:
       maybe change this to incrementReportedErrorCount so it is specific to reporter errors?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org