[jira] [Commented] (QUICKSTEP-106) Fuse-Hash-Select

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/QUICKSTEP-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176974#comment-16176974 ] 

ASF GitHub Bot commented on QUICKSTEP-106:
------------------------------------------

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/300#discussion_r140575077
  
    --- Diff: query_optimizer/rules/FuseHashSelect.cpp ---
    @@ -0,0 +1,91 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + **/
    +
    +#include "query_optimizer/rules/FuseHashSelect.hpp"
    +
    +#include <algorithm>
    +#include <cstddef>
    +#include <unordered_set>
    +#include <vector>
    +
    +#include "query_optimizer/expressions/AttributeReference.hpp"
    +#include "query_optimizer/expressions/ExpressionUtil.hpp"
    +#include "query_optimizer/expressions/PatternMatcher.hpp"
    +#include "query_optimizer/expressions/Predicate.hpp"
    +#include "query_optimizer/physical/HashJoin.hpp"
    +#include "query_optimizer/physical/PatternMatcher.hpp"
    +#include "query_optimizer/physical/Physical.hpp"
    +#include "query_optimizer/physical/PhysicalType.hpp"
    +#include "query_optimizer/physical/Selection.hpp"
    +
    +#include "glog/logging.h"
    --- End diff --
    
    Do we actually use sth from all these headers above? If no, please remove the unused headers.


> Fuse-Hash-Select
> ----------------
>
>                 Key: QUICKSTEP-106
>                 URL: https://issues.apache.org/jira/browse/QUICKSTEP-106
>             Project: Apache Quickstep
>          Issue Type: New Feature
>          Components: Query Execution, Query Optimizer
>            Reporter: Dylan Bacon
>
> Adding support for a physical plan optimization rule to fuse a selection node in the build side of a hash join into a table reference with the predicate moved directly into the hash join for execution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)