You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/07/14 05:33:48 UTC

[GitHub] [helix] jiajunwang commented on a change in pull request #1119: Add sync() call first for new session handling

jiajunwang commented on a change in pull request #1119:
URL: https://github.com/apache/helix/pull/1119#discussion_r454111786



##########
File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -1165,20 +1177,92 @@ private void reconnect() {
     }
   }
 
+  private class SyncContext {

Review comment:
       I might miss some points here. But if we call DefaultCallback.waitForSuccess() in the new session handling method at where you call the latch.await(), will it do the same trick?
   
   Regarding the retry logic, it is simple to extend the DefaultCallback.needRetry() in the SyncCallbackHandler.
   1. make needRetry() protected.
   2. override it in the new SyncCallbackHandler class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org