You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/29 17:23:04 UTC
Review Request 66367: Made the master drop `RECONCILE_OPERATIONS`
calls from v0 schedulers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66367/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Repository: mesos
Description
-------
Made the master drop `RECONCILE_OPERATIONS` calls from v0 schedulers.
Diffs
-----
src/master/master.cpp 20692c36c021fdae91de0b156f26fc56cf7c4f45
Diff: https://reviews.apache.org/r/66367/diff/1/
Testing
-------
Existing tests pass on GNU/Linux.
Thanks,
Gaston Kleiman
Re: Review Request 66367: Made the master drop `RECONCILE_OPERATIONS`
calls from v0 schedulers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66367/#review200208
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66362', '66363', '66364', '66365', '66366', '66367']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66367
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66367/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (110 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1065 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (35 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (44 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (81 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (819 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (846 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (840 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (868 ms total)
[----------] Global test environment tear-down
[==========] 949 tests from 94 test cases ran. (442209 ms total)
[ PASSED ] 948 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 214 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66367/logs/mesos-tests-stderr.log):
```
I0329 19:30:53.700094 5100 slave.cpp:3877] Shutting down framework aa2e1ff1-c8c0-4e5c-b6ed-47ac8649ff2b-0000
I0329 19:30:53.700094 1244 master.cpp:10449] Updating the state of task fa9e072e-0db1-459e-979b-e819b1afe747 of framework aa2e1ff1-c8c0-4e5c-b6ed-47ac8649ff2b-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0329 19:30:53.700094 5100 slaI0329 19:30:53.516070 8764 exec.cpp:162] Version: 1.6.0
I0329 19:30:53.543056 3296 exec.cpp:236] Executor registered on agent aa2e1ff1-c8c0-4e5c-b6ed-47ac8649ff2b-S0
I0329 19:30:53.547063 4148 executor.cpp:176] Received SUBSCRIBED event
I0329 19:30:53.553061 4148 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0329 19:30:53.553061 4148 executor.cpp:176] Received LAUNCH event
I0329 19:30:53.558060 4148 executor.cpp:648] Starting task fa9e072e-0db1-459e-979b-e819b1afe747
I0329 19:30:53.643072 4148 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0329 19:30:53.674059 4148 executor.cpp:661] Forked command at 9116
I0329 19:30:53.705070 2364 exec.cpp:445] Executor asked to shutdown
I0329 19:30:53.705070 7112 executor.cpp:176] Received SHUTDOWN event
I0329 19:30:53.705070 7112 executor.cpp:758] Shutting down
I0329 19:30:53.706058 7112 executor.cpp:868] Sending SIGTERM to process tree at pid 9ve.cpp:6574] Shutting down executor 'fa9e072e-0db1-459e-979b-e819b1afe747' of framework aa2e1ff1-c8c0-4e5c-b6ed-47ac8649ff2b-0000 at executor(1)@10.3.1.8:50049
I0329 19:30:53.703068 1244 master.cpp:10548] Removing task fa9e072e-0db1-459e-979b-e819b1afe747 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework aa2e1ff1-c8c0-4e5c-b6ed-47ac8649ff2b-0000 on agent aa2e1ff1-c8c0-4e5c-b6ed-47ac8649ff2b-S0 at slave(418)@10.3.1.8:50028 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0329 19:30:53.704071 5100 slave.cpp:923] Agent terminating
W0329 19:30:53.704071 5100 slave.cpp:3873] Ignoring shutdown framework aa2e1ff1-c8c0-4e5c-b6ed-47ac8649ff2b-0000 because it is terminating
I0329 19:30:53.706058 6376 hierarchical.cpp:344] Removed framework aa2e1ff1-c8c0-4e5c-b6ed-47ac8649ff2b-0000
I0329 19:30:53.706058 1244 master.cpp:1295] Agent aa2e1ff1-c8c0-4e5c-b6ed-47ac8649ff2b-S0 at slave(418)@10.3.1.8:50028 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0329 19:30:53.707067 1244 master.cpp:3286] Disconnecting agent aa2e1ff1-c8c0-4e5c-b6ed-47ac8649ff2b-S0 at slave(418)@10.3.1.8:50028 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0329 19:30:53.707067 1244 master.cpp:3305] Deactivating agent aa2e1ff1-c8c0-4e5c-b6ed-47ac8649ff2b-S0 at slave(418)@10.3.1.8:50028 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0329 19:30:53.707067 5100 hierarchical.cpp:766] Agent aa2e1ff1-c8c0-4e5c-b6ed-47ac8649ff2b-S0 deactivated
I0329 19:30:53.709091 9556 containerizer.cpp:2338] Destroying container 0cee8402-9190-426c-8561-04f671bd1c62 in RUNNING state
I0329 19:30:53.709091 9556 containerizer.cpp:2952] Transitioning the state of container 0cee8402-9190-426c-8561-04f671bd1c62 from RUNNING to DESTROYING
I0329 19:30:53.710074 9556 launcher.cpp:156] Asked to destroy container 0cee8402-9190-426c-8561-04f671bd1c62
I0329 19:30:53.803325 5176 containerizer.cpp:2791] Container 0cee8402-9190-426c-8561-04f671bd1c62 has exited
I0329 19:30:53.837349 11140 master.cpp:1137] Master terminating
I0329 19:30:53.840354 6376 hierarchical.cpp:609] Removed agent aa2e1ff1-c8c0-4e5c-b6ed-47ac8649ff2b-S0
I0329 19:30:54.231737 10676 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 29, 2018, 5:23 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66367/
> -----------------------------------------------------------
>
> (Updated March 29, 2018, 5:23 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the master drop `RECONCILE_OPERATIONS` calls from v0 schedulers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 20692c36c021fdae91de0b156f26fc56cf7c4f45
>
>
> Diff: https://reviews.apache.org/r/66367/diff/1/
>
>
> Testing
> -------
>
> Existing tests pass on GNU/Linux.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 66367: Made the master drop `RECONCILE_OPERATIONS`
calls from v0 schedulers.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66367/#review200311
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66362, 66363, 66364, 66365, 66366, 66367]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 29, 2018, 5:23 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66367/
> -----------------------------------------------------------
>
> (Updated March 29, 2018, 5:23 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the master drop `RECONCILE_OPERATIONS` calls from v0 schedulers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 20692c36c021fdae91de0b156f26fc56cf7c4f45
>
>
> Diff: https://reviews.apache.org/r/66367/diff/2/
>
>
> Testing
> -------
>
> Existing tests pass on GNU/Linux.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 66367: Made the master drop `RECONCILE_OPERATIONS`
calls from v0 schedulers.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66367/#review200241
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On March 29, 2018, 5:23 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66367/
> -----------------------------------------------------------
>
> (Updated March 29, 2018, 5:23 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the master drop `RECONCILE_OPERATIONS` calls from v0 schedulers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 20692c36c021fdae91de0b156f26fc56cf7c4f45
>
>
> Diff: https://reviews.apache.org/r/66367/diff/1/
>
>
> Testing
> -------
>
> Existing tests pass on GNU/Linux.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 66367: Made the master drop `RECONCILE_OPERATIONS`
calls from v0 schedulers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66367/#review200303
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66362', '66363', '66364', '66365', '66366', '66367']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66367
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66367/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (117 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1113 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (45 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (50 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (98 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (761 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (786 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (833 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (868 ms total)
[----------] Global test environment tear-down
[==========] 949 tests from 94 test cases ran. (448854 ms total)
[ PASSED ] 948 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 214 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66367/logs/mesos-tests-stderr.log):
```
I0402 18:15:00.948766 5704 master.cpp:10449] Updating the state of task 15e3090d-5701-425f-88ec-a189e9051f0a of framework 3b213ea3-4a73-4657-b491-98f15c651fd1-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0402 18:15:00.948766 3684 slave.cpp:3877I0402 18:15:00.754611 10520 exec.cpp:162] Version: 1.6.0
I0402 18:15:00.785619 5908 exec.cpp:236] Executor registered on agent 3b213ea3-4a73-4657-b491-98f15c651fd1-S0
I0402 18:15:00.792613 11288 executor.cpp:176] Received SUBSCRIBED event
I0402 18:15:00.796603 11288 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0402 18:15:00.797605 11288 executor.cpp:176] Received LAUNCH event
I0402 18:15:00.802603 11288 executor.cpp:648] Starting task 15e3090d-5701-425f-88ec-a189e9051f0a
I0402 18:15:00.889614 11288 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0402 18:15:00.917609 11288 executor.cpp:661] Forked command at 7872
I0402 18:15:00.951609 8948 exec.cpp:445] Executor asked to shutdown
I0402 18:15:00.952610 8340 executor.cpp:176] Received SHUTDOWN event
I0402 18:15:00.952610 8340 executor.cpp:758] Shutting down
I0402 18:15:00.952610 8340 executor.cpp:868] Sending SIGTERM to process tree at pid 7] Shutting down framework 3b213ea3-4a73-4657-b491-98f15c651fd1-0000
I0402 18:15:00.949607 3684 slave.cpp:6574] Shutting down executor '15e3090d-5701-425f-88ec-a189e9051f0a' of framework 3b213ea3-4a73-4657-b491-98f15c651fd1-0000 at executor(1)@10.3.1.8:53036
I0402 18:15:00.950610 3684 slave.cpp:923] Agent terminating
W0402 18:15:00.950610 3684 slave.cpp:3873] Ignoring shutdown framework 3b213ea3-4a73-4657-b491-98f15c651fd1-0000 because it is terminating
I0402 18:15:00.950610 5704 master.cpp:10548] Removing task 15e3090d-5701-425f-88ec-a189e9051f0a with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 3b213ea3-4a73-4657-b491-98f15c651fd1-0000 on agent 3b213ea3-4a73-4657-b491-98f15c651fd1-S0 at slave(418)@10.3.1.8:53015 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0402 18:15:00.953610 5704 master.cpp:1295] Agent 3b213ea3-4a73-4657-b491-98f15c651fd1-S0 at slave(418)@10.3.1.8:53015 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0402 18:15:00.953610 5704 master.cpp:3286] Disconnecting agent 3b213ea3-4a73-4657-b491-98f15c651fd1-S0 at slave(418)@10.3.1.8:53015 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0402 18:15:00.954628 5704 master.cpp:3305] Deactivating agent 3b213ea3-4a73-4657-b491-98f15c651fd1-S0 at slave(418)@10.3.1.8:53015 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0402 18:15:00.954628 2960 hierarchical.cpp:344] Removed framework 3b213ea3-4a73-4657-b491-98f15c651fd1-0000
I0402 18:15:00.954628 2960 hierarchical.cpp:766] Agent 3b213ea3-4a73-4657-b491-98f15c651fd1-S0 deactivated
I0402 18:15:00.955619 11792 containerizer.cpp:2338] Destroying container aa577bbb-68f1-49d8-b1be-891fccc67466 in RUNNING state
I0402 18:15:00.955619 11792 containerizer.cpp:2952] Transitioning the state of container aa577bbb-68f1-49d8-b1be-891fccc67466 from RUNNING to DESTROYING
I0402 18:15:00.956641 11792 launcher.cpp:156] Asked to destroy container aa577bbb-68f1-49d8-b1be-891fccc67466
I0402 18:15:01.012640 5704 containerizer.cpp:2791] Container aa577bbb-68f1-49d8-b1be-891fccc67466 has exited
I0402 18:15:01.047646 8480 master.cpp:1137] Master terminating
I0402 18:15:01.050644 2600 hierarchical.cpp:609] Removed agent 3b213ea3-4a73-4657-b491-98f15c651fd1-S0
I0402 18:15:01.555492 9292 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 29, 2018, 5:23 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66367/
> -----------------------------------------------------------
>
> (Updated March 29, 2018, 5:23 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the master drop `RECONCILE_OPERATIONS` calls from v0 schedulers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 20692c36c021fdae91de0b156f26fc56cf7c4f45
>
>
> Diff: https://reviews.apache.org/r/66367/diff/2/
>
>
> Testing
> -------
>
> Existing tests pass on GNU/Linux.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 66367: Made the master drop `RECONCILE_OPERATIONS`
calls from v0 schedulers.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66367/#review200212
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66362, 66363, 66364, 66365, 66366, 66367]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 29, 2018, 5:23 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66367/
> -----------------------------------------------------------
>
> (Updated March 29, 2018, 5:23 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the master drop `RECONCILE_OPERATIONS` calls from v0 schedulers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 20692c36c021fdae91de0b156f26fc56cf7c4f45
>
>
> Diff: https://reviews.apache.org/r/66367/diff/1/
>
>
> Testing
> -------
>
> Existing tests pass on GNU/Linux.
>
>
> Thanks,
>
> Gaston Kleiman
>
>