You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/28 12:54:30 UTC
[GitHub] [airflow] potiuk opened a new pull request, #26022: Remove remaining fromJson in a few runs-on
potiuk opened a new pull request, #26022:
URL: https://github.com/apache/airflow/pull/26022
The change #26018 introduced better way of calculating runs-on
using Breeze, but it missed a few cases where old mechanism used
fromJson (where it was not necessary and harmful actually).
This fixes the problem.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26022: Remove remaining fromJson in a few runs-on
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26022:
URL: https://github.com/apache/airflow/pull/26022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26022: Remove remaining fromJson in a few runs-on
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26022:
URL: https://github.com/apache/airflow/pull/26022#issuecomment-1229462445
Looks good :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #26022: Remove remaining fromJson in a few runs-on
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #26022: Remove remaining fromJson in a few runs-on
URL: https://github.com/apache/airflow/pull/26022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26022: Remove remaining fromJson in a few runs-on
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26022:
URL: https://github.com/apache/airflow/pull/26022#issuecomment-1229464088
Reopened with "use public runners" label to test this case too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26022: Remove remaining fromJson in a few runs-on
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26022:
URL: https://github.com/apache/airflow/pull/26022#issuecomment-1229464657
Works:
<img width="639" alt="Screenshot 2022-08-28 at 16 01 27" src="https://user-images.githubusercontent.com/595491/187077730-640235ba-7dd4-4223-8fc5-b5bc9ac8c006.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26022: Remove remaining fromJson in a few runs-on
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26022:
URL: https://github.com/apache/airflow/pull/26022#issuecomment-1229452821
Testing it also in https://github.com/higrys/airflow/pull/2 and https://github.com/potiuk/airflow/actions/runs/2943099830 - it's notoriously difficult if all the cases are working when we have this dual-workflows in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org