[GitHub] [nifi] simonbence commented on a diff in pull request #6719: NIFI-10874 Fixing issue with multiple levels of versioned flows

[GitBox <gi...@apache.org>]

simonbence commented on code in PR #6719:
URL: https://github.com/apache/nifi/pull/6719#discussion_r1033625778


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java:
##########
@@ -2013,7 +2014,13 @@ public Response createProcessGroup(
             // Step 2: Retrieve flow from Flow Registry
             final RegisteredFlowSnapshot flowSnapshot = getFlowFromRegistry(versionControlInfo);
 
-            // Step 3: Resolve Bundle info
+            // Step 3: Enrich version control info came from UI
+            final VersionedFlowCoordinates versionedFlowCoordinates = flowSnapshot.getFlowContents().getVersionedFlowCoordinates(); // If not null....

Review Comment:
   You are correct, I forgot the comment there from development. In the line below the null check for `versionedFlowCoordinates` happens. My understanding is that, `getFlowContents` should not return `null`. I will remove the comment if you are okay with this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org