You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by "Craig Condit (Jira)" <ji...@apache.org> on 2023/05/25 15:41:00 UTC
[jira] [Resolved] (YUNIKORN-1746) Improve the performance of nodeInfoListerImpl.List()
[ https://issues.apache.org/jira/browse/YUNIKORN-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Condit resolved YUNIKORN-1746.
------------------------------------
Fix Version/s: 1.3.0
Target Version: 1.3.0
Resolution: Fixed
Merged to master.
> Improve the performance of nodeInfoListerImpl.List()
> ----------------------------------------------------
>
> Key: YUNIKORN-1746
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1746
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> Performance data (cpu and heap profiles) indicate that we can improve the performance of {{nodeInfoListerImpl.List()}}.
> This is the code which is located in the shim:
> {noformat}
> func (n nodeInfoListerImpl) List() ([]*framework.NodeInfo, error) {
> nodes := n.cache.GetNodesInfoMap()
> nodeList := make([]*framework.NodeInfo, 0, len(nodes))
> for _, node := range nodes {
> nodeList = append(nodeList, node)
> }
> return nodeList, nil
> }
> {noformat}
> We're supposed to be having a read lock on the cache, which is done outside this method.
> The problem is, the nodes info map only changes if a node joins or leaves the cluster. A lot of copying is done here, we generate a lot of waste. This method is called very frequently, because predicates need this list and predicates always run for each pod by default.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org