You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "no1wudi (via GitHub)" <gi...@apache.org> on 2023/03/20 08:51:09 UTC

[GitHub] [nuttx-apps] no1wudi opened a new pull request, #1669: Fix some hard coded buffer len of snprintf

no1wudi opened a new pull request, #1669:
URL: https://github.com/apache/nuttx-apps/pull/1669

   ## Summary
   Fix some hard coded buffer len of snprintf
   ## Impact
   minor
   ## Testing
   CI
   
   Please ignore nxsytle warning from origin code.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] acassis merged pull request #1669: Fix some hard coded buffer len of snprintf

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #1669:
URL: https://github.com/apache/nuttx-apps/pull/1669


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1669: Fix some hard coded buffer len of snprintf

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #1669:
URL: https://github.com/apache/nuttx-apps/pull/1669#discussion_r1141800816


##########
system/vi/vi.c:
##########
@@ -753,7 +753,7 @@ static void vi_setcursor(FAR struct vi_s *vi, uint16_t row, uint16_t column)
 
   /* Format the cursor position command.  The origin is (1,1). */
 
-  len = snprintf(buffer, 16, g_fmtcursorpos, row + 1, column + 1);
+  len = snprintf(buffer, sizeof(buffer), g_fmtcursorpos, row + 1, column + 1);

Review Comment:
   Please fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org