[jira] [Commented] (IMAGING-151) ColorGroup.color_counts is mutable public List and is multiply sorted

["Bruno P. Kinoshita (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMAGING-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996586#comment-16996586 ] 

Bruno P. Kinoshita commented on IMAGING-151:
--------------------------------------------

Hi [~sebb] PR submitted: [https://github.com/apache/commons-imaging/pull/64,] let me know if you have some spare time to review it later. Thanks

 

> ColorGroup.color_counts is mutable public List and is multiply sorted
> ---------------------------------------------------------------------
>
>                 Key: IMAGING-151
>                 URL: https://issues.apache.org/jira/browse/IMAGING-151
>             Project: Commons Imaging
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> ColorGroup.color_counts is a public mutable List.
> Also the List is re-sorted in several places
> It looks like the field is only used within the package, so can be package protected.
> However it seems odd that the shared list is re-sorted by
> MedianCutLongestAxisImplementation.doCut
> and
> MedianCutMostPopulatedBoxesImplementation.performNextMedianCut (twice)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)