You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/09/14 19:14:37 UTC
[GitHub] couchdb-fauxton pull request: Specifying correct params for before...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/523
Specifying correct params for before/afterEach
The NW docs say the done() callback is the second param, not first.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton nightwatch-helper-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #523
----
commit c427db4d946867d46d4d9997e42e9eb4a1aa6f02
Author: Ben Keen <be...@gmail.com>
Date: 2015-09-14T15:01:53Z
Specifying correct params for before/afterEach
The NW docs say the done() callback is the second param, not first.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Specifying correct params for before...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/523#issuecomment-140515934
Ignore above, it was a couch issue. Re-running CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Specifying correct params for before...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/523#issuecomment-140156967
+1 if green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Specifying correct params for before...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/523#issuecomment-140217607
I've been battling trying to get couch going all day. It's possible I've just borked something that I don't understand, but it may also be couch. Some info:
- Ysing the latest couch code for me prevents Fauxton working at all. All requests just hang.
- reverting to an earlier couch SHA (eb34513 - the last sha that was working for me) gets Fauxton running again. However, the load balancer seems wonky: creating a new DB request only adds it to a single node, not all nodes. Thus NW tests fail erratically - in a very similar fashion to what's happening on this ticket. Could be coincidence.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Specifying correct params for before...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---