[arrow] branch master updated: ARROW-5836: [Java][FlightRPC] Skip Flight domain socket test when path too long

[ks...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

kszucs pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 41c737d  ARROW-5836: [Java][FlightRPC] Skip Flight domain socket test when path too long
41c737d is described below

commit 41c737dea0ee31741a10cf358ac1d8f0055027c3
Author: David Li <li...@gmail.com>
AuthorDate: Thu Jul 4 09:52:24 2019 +0200

    ARROW-5836: [Java][FlightRPC] Skip Flight domain socket test when path too long
    
    Domain sockets have a platform-dependent path length limit. The release verification script on OSX tends to set a temporary directory that makes the test exceed this. Rather than hardcoding `/tmp` or some other directory, we skip the test instead.
    
    Author: David Li <li...@gmail.com>
    
    Closes #4793 from lihalite/arrow-5836 and squashes the following commits:
    
    67eb3b7bd <David Li> Skip Flight domain socket test when path too long
---
 .../src/test/java/org/apache/arrow/flight/TestServerOptions.java       | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/java/flight/src/test/java/org/apache/arrow/flight/TestServerOptions.java b/java/flight/src/test/java/org/apache/arrow/flight/TestServerOptions.java
index e3ac390..c745de9 100644
--- a/java/flight/src/test/java/org/apache/arrow/flight/TestServerOptions.java
+++ b/java/flight/src/test/java/org/apache/arrow/flight/TestServerOptions.java
@@ -38,6 +38,9 @@ public class TestServerOptions {
     Assume.assumeTrue("We have a native transport available", FlightTestUtil.isNativeTransportAvailable());
     final File domainSocket = File.createTempFile("flight-unit-test-", ".sock");
     Assert.assertTrue(domainSocket.delete());
+    // Domain socket paths have a platform-dependent limit. Set a conservative limit and skip the test if the temporary
+    // file name is too long. (We do not assume a particular platform-dependent temporary directory path.)
+    Assume.assumeTrue("The domain socket path is not too long", domainSocket.getAbsolutePath().length() < 100);
     final Location location = Location.forGrpcDomainSocket(domainSocket.getAbsolutePath());
     try (
         BufferAllocator a = new RootAllocator(Long.MAX_VALUE);