[GitHub] [spark] cloud-fan edited a comment on pull request #34030: [SPARK-36790][SQL] Update user-facing catalog to adapt CatalogPlugin

[GitBox <gi...@apache.org>]

cloud-fan edited a comment on pull request #34030:
URL: https://github.com/apache/spark/pull/34030#issuecomment-924977190


   OK let's go with the first idea then. Another question is, do we need to add more function overloads with an extra catalog parameter? e.g.
   ```
   def createTable(table)
   def createTable(database, table)
   def createTable(catalog, database, table)
   ```
   
   My preference is to deprecate the existing `def createTable(database, table)` and ask users to use `def createTable(table)` with qualified names. I think it's a bad idea to have many overloads, and we may hit more problems as `namespace` is not a single string but a string[].
   
   For the existing `def createTable(database, table)`, we can create the table in the current catalog.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org