You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "sekikn (via GitHub)" <gi...@apache.org> on 2023/08/14 06:17:43 UTC
[GitHub] [parquet-mr] sekikn commented on a diff in pull request #1131: PARQUET-2333: Support bzip2 and xz compression in the to-avro subcommand
sekikn commented on code in PR #1131:
URL: https://github.com/apache/parquet-mr/pull/1131#discussion_r1293013732
##########
parquet-cli/pom.xml:
##########
@@ -110,6 +110,12 @@
<artifactId>avro</artifactId>
<version>${avro.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.tukaani</groupId>
Review Comment:
I think it has no license issue, since [its Java implementation](https://tukaani.org/xz/java.html) is [public domain](https://github.com/tukaani-project/xz-java/blob/v1.9/COPYING), which is classified into [Category A](https://www.apache.org/legal/resolved.html#handling-public-domain-licensed-works). It also doesn't seem to have any dependent libraries.
As other examples, Druid, HBase and Spark already include it.
https://github.com/apache/druid/blob/druid-27.0.0/pom.xml#L527-L531
https://github.com/apache/hbase/blob/rel/2.5.5/pom.xml#L1470-L1474
https://github.com/apache/spark/blob/v3.4.1/pom.xml#L1489-L1493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org