You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/17 22:45:05 UTC
[GitHub] codecov-io edited a comment on issue #5662: Minor improvements to
SQL Lab UI
codecov-io edited a comment on issue #5662: Minor improvements to SQL Lab UI
URL: https://github.com/apache/incubator-superset/pull/5662#issuecomment-414006081
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5662?src=pr&el=h1) Report
> Merging [#5662](https://codecov.io/gh/apache/incubator-superset/pull/5662?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5a4b70dad727e32427f498a1d3bd97a3ef119013?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5662 +/- ##
=========================================
+ Coverage 63.49% 63.5% +<.01%
=========================================
Files 360 360
Lines 22889 22891 +2
Branches 2549 2551 +2
=========================================
+ Hits 14534 14536 +2
Misses 8340 8340
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...t/assets/src/SqlLab/components/CopyQueryTabUrl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9Db3B5UXVlcnlUYWJVcmwuanN4) | `78.57% <ø> (ø)` | :arrow_up: |
| [...uperset/assets/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9Tb3V0aFBhbmUuanN4) | `88.57% <ø> (ø)` | :arrow_up: |
| [...rset/assets/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UYWJsZUVsZW1lbnQuanN4) | `95.23% <ø> (ø)` | :arrow_up: |
| [...ets/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UZW1wbGF0ZVBhcmFtc0VkaXRvci5qc3g=) | `91.83% <ø> (ø)` | :arrow_up: |
| [.../assets/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3JMZWZ0QmFyLmpzeA==) | `92.52% <100%> (ø)` | :arrow_up: |
| [superset/assets/src/SqlLab/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/5662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMuanM=) | `58.18% <100%> (ø)` | :arrow_up: |
| [superset/assets/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/5662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9yZWR1eFV0aWxzLmpz) | `75.4% <100%> (+0.83%)` | :arrow_up: |
| [.../assets/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UYWJiZWRTcWxFZGl0b3JzLmpzeA==) | `90.99% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5662?src=pr&el=footer). Last update [5a4b70d...1878b0d](https://codecov.io/gh/apache/incubator-superset/pull/5662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org