You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/15 20:54:25 UTC
[GitHub] [kafka] cmccabe opened a new pull request #11064: MINOR: enable reassign_partitions_test.py for kraft
cmccabe opened a new pull request #11064:
URL: https://github.com/apache/kafka/pull/11064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #11064: MINOR: enable reassign_partitions_test.py for kraft
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #11064:
URL: https://github.com/apache/kafka/pull/11064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11064:
URL: https://github.com/apache/kafka/pull/11064#issuecomment-882580369
Thanks for the explanation @rondagostino.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11064:
URL: https://github.com/apache/kafka/pull/11064#issuecomment-882580369
Thanks for the explanation @rondagostino.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #11064: MINOR: enable reassign_partitions_test.py for kraft
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #11064:
URL: https://github.com/apache/kafka/pull/11064#discussion_r671722911
##########
File path: tests/kafkatest/tests/core/reassign_partitions_test.py
##########
@@ -130,8 +133,9 @@ def move_start_offset(self):
@cluster(num_nodes=8)
@matrix(bounce_brokers=[True, False],
- reassign_from_offset_zero=[True, False])
- def test_reassign_partitions(self, bounce_brokers, reassign_from_offset_zero):
+ reassign_from_offset_zero=[True, False],
+ metadata_quorum=quorum.all_non_upgrade)
+ def test_reassign_partitions(self, bounce_brokers, reassign_from_offset_zero, metadata_quorum):
Review comment:
How is `metadata_quorum` used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #11064: MINOR: enable reassign_partitions_test.py for kraft
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #11064:
URL: https://github.com/apache/kafka/pull/11064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft
Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #11064:
URL: https://github.com/apache/kafka/pull/11064#issuecomment-882573376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11064:
URL: https://github.com/apache/kafka/pull/11064#issuecomment-882580369
Thanks for the explanation @rondagostino.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11064:
URL: https://github.com/apache/kafka/pull/11064#issuecomment-881931368
cc @rondagostino
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft
Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #11064:
URL: https://github.com/apache/kafka/pull/11064#issuecomment-882573376
LGTM
> How is `metadata_quorum` used?
`KafkaService` uses the value of `metadata_quorum` to determine what type of metadata quorum the test should use, and there are a bunch of things that have to happen if the value indicates co-located or remote KRaft (broker config changes, potentially creating/configuring/starting a remote controller quorum). The actual test code itself (`test_reassign_partitions()` in this case) doesn't use the value directly, but we have to declare the parameter in order to inject the value.
`KafkaService` generally uses the injected value by invoking either:
1. `self.quorum_info = quorum.ServiceQuorumInfo(self, context)` to get the general quorum information for the service (whether it is using ZooKeeper, co-located KRaft, or remote KRaft)
-- or --
2. `quorum.NodeQuorumInfo(self.quorum_info, node)` to get the specific details for a particular node (i.e. what it's `broker.roles` value should be, since it is potentially different across the different nodes of a Kafka cluster when using co-located KRaft)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #11064: MINOR: enable reassign_partitions_test.py for kraft
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #11064:
URL: https://github.com/apache/kafka/pull/11064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft
Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #11064:
URL: https://github.com/apache/kafka/pull/11064#issuecomment-882577262
> `KafkaService` uses the value of `metadata_quorum` to determine what type of metadata quorum the test should use
On more thing: the code assumes `quorum.ZK` if no value was injected so that existing test definitions continue to work. See https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/kafka/quorum.py#L33-L40 for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft
Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #11064:
URL: https://github.com/apache/kafka/pull/11064#issuecomment-882573376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org