You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2017/11/02 05:53:16 UTC
[kudu-CR] KUDU-1411: Implement HT timestamp propagation in KuduScanToken
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8452
Change subject: KUDU-1411: Implement HT timestamp propagation in KuduScanToken
......................................................................
KUDU-1411: Implement HT timestamp propagation in KuduScanToken
This patch adds timpestamp propagation in KuduScanToken for java client,
so that deserializing a ScanToken results in a propagating the timestamp
of the serializer into the deserializer.
Change-Id: If427be16d1fff60271b362134686793ffdbc19f9
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
2 files changed, 41 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/8452/1
--
To view, visit http://gerrit.cloudera.org:8080/8452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If427be16d1fff60271b362134686793ffdbc19f9
Gerrit-Change-Number: 8452
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] KUDU-1411: Implement HT timestamp propagation in KuduScanToken
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8452
to look at the new patch set (#2).
Change subject: KUDU-1411: Implement HT timestamp propagation in KuduScanToken
......................................................................
KUDU-1411: Implement HT timestamp propagation in KuduScanToken
This patch adds timpestamp propagation in KuduScanToken for java client,
so that deserializing a ScanToken results in a propagating the timestamp
of the serializer into the deserializer.
Change-Id: If427be16d1fff60271b362134686793ffdbc19f9
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
2 files changed, 41 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/8452/2
--
To view, visit http://gerrit.cloudera.org:8080/8452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If427be16d1fff60271b362134686793ffdbc19f9
Gerrit-Change-Number: 8452
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1411: Implement HT timestamp propagation in KuduScanToken
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8452 )
Change subject: KUDU-1411: Implement HT timestamp propagation in KuduScanToken
......................................................................
Patch Set 1:
Another existing flaky test FlexPartitioningITest. Should not be related to the change.
--
To view, visit http://gerrit.cloudera.org:8080/8452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If427be16d1fff60271b362134686793ffdbc19f9
Gerrit-Change-Number: 8452
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 02 Nov 2017 19:17:32 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1411: Implement HT timestamp propagation in KuduScanToken
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8452 )
Change subject: KUDU-1411: Implement HT timestamp propagation in KuduScanToken
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8452/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java:
http://gerrit.cloudera.org:8080/#/c/8452/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java@101
PS1, Line 101: static byte[] serialize(ScanTokenPB message) throws IOException {
> Can this be package private? We really try not to expose protobuf classes
Done
--
To view, visit http://gerrit.cloudera.org:8080/8452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If427be16d1fff60271b362134686793ffdbc19f9
Gerrit-Change-Number: 8452
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 07 Nov 2017 01:15:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1411: Implement HT timestamp propagation in KuduScanToken
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8452 )
Change subject: KUDU-1411: Implement HT timestamp propagation in KuduScanToken
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8452/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java:
http://gerrit.cloudera.org:8080/#/c/8452/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java@101
PS1, Line 101: public static byte[] serialize(ScanTokenPB message) throws IOException {
Can this be package private? We really try not to expose protobuf classes if possible n the public API.
--
To view, visit http://gerrit.cloudera.org:8080/8452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If427be16d1fff60271b362134686793ffdbc19f9
Gerrit-Change-Number: 8452
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 06 Nov 2017 17:25:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1411: Implement HT timestamp propagation in KuduScanToken
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8452 )
Change subject: KUDU-1411: Implement HT timestamp propagation in KuduScanToken
......................................................................
KUDU-1411: Implement HT timestamp propagation in KuduScanToken
This patch adds timpestamp propagation in KuduScanToken for java client,
so that deserializing a ScanToken results in a propagating the timestamp
of the serializer into the deserializer.
Change-Id: If427be16d1fff60271b362134686793ffdbc19f9
Reviewed-on: http://gerrit.cloudera.org:8080/8452
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
2 files changed, 41 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Dan Burkert: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If427be16d1fff60271b362134686793ffdbc19f9
Gerrit-Change-Number: 8452
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1411: Implement HT timestamp propagation in KuduScanToken
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8452 )
Change subject: KUDU-1411: Implement HT timestamp propagation in KuduScanToken
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If427be16d1fff60271b362134686793ffdbc19f9
Gerrit-Change-Number: 8452
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 07 Nov 2017 19:14:18 +0000
Gerrit-HasComments: No