You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/09/20 04:01:11 UTC

[GitHub] [thrift] balazsgrill commented on a change in pull request #2455: Modified build tags to allow js/wasm target

balazsgrill commented on a change in pull request #2455:
URL: https://github.com/apache/thrift/pull/2455#discussion_r711864539



##########
File path: lib/go/thrift/socket_windows_conn.go
##########
@@ -1,4 +1,4 @@
-// +build windows
+// +build windows wasm

Review comment:
       Done. Do you need me to manually sqash the commits?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org