You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2023/08/17 07:18:10 UTC

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7848: server: get only Ready ISO to mount

weizhouapache commented on code in PR #7848:
URL: https://github.com/apache/cloudstack/pull/7848#discussion_r1296776519


##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1215,7 +1215,7 @@ public TemplateInfo prepareIso(long isoId, long dcId, Long hostId, Long poolId)
             tmplt = _tmplFactory.getReadyBypassedTemplateOnPrimaryStore(isoId, poolId, hostId);
             bypassed = true;
         } else {
-            tmplt = _tmplFactory.getTemplate(isoId, DataStoreRole.Image, dcId);
+            tmplt = _tmplFactory.getReadyTemplateOnImageStore(isoId, dcId);

Review Comment:
   @DaanHoogland 
   yes, they both look for Templates /isos on image stores.
   The difference is, `getTemplate` do not have the check on State



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org