[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #4764: [hotfix][kafka] Fix the problem that the partition information cannot be obtained when kafka is restored

["EricJoy2048 (via GitHub)" <gi...@apache.org>]

EricJoy2048 commented on code in PR #4764:
URL: https://github.com/apache/incubator-seatunnel/pull/4764#discussion_r1197287762


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -369,7 +365,6 @@ public Map<TopicPartition, Long> listConsumerGroupOffsets(Collection<TopicPartit
 
     private void discoverySplits() throws ExecutionException, InterruptedException {
         fetchPendingPartitionSplit();
-        assignSplit();

Review Comment:
   I think there might be a problem here. If all readers are registered and a new split be discover, It can not be assign.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org