You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cquptEthan <gi...@git.apache.org> on 2016/07/08 01:06:51 UTC
[GitHub] zeppelin pull request #1151: Fonted download error code fix
GitHub user cquptEthan opened a pull request:
https://github.com/apache/zeppelin/pull/1151
Fonted download error code fix
### What is this PR for?
Fix chinese garbled open with Excel #714
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Add Bom Header
### What is the Jira issue?
[ZEPPELIN-672](https://issues.apache.org/jira/browse/ZEPPELIN-672)
### How should this be tested?
create a paragraph with chinses chars data in %table view.
download with CSV format and open with Excel.
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cquptEthan/incubator-zeppelin fonted-download-error-code-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1151.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1151
----
commit 46628c265d8d6f2ed8493d5dfaf95638fd7a6e74
Author: ZhangEthan <22...@qq.com>
Date: 2016-07-08T00:33:03Z
Merge branch 'apache/master' into fonted-download-error-code-fix
commit a4a99b4c210c2662f16d8a1aa072943e7da463c1
Author: ZhangEthan <22...@qq.com>
Date: 2016-07-08T00:47:25Z
Fix chinese garbled in Excel
add bom header in front-end download file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1151: Fonted download chinese garbled fix
Posted by ebuildy <gi...@git.apache.org>.
Github user ebuildy commented on the issue:
https://github.com/apache/zeppelin/pull/1151
Hello, the Jira issue is still opened https://issues.apache.org/jira/browse/ZEPPELIN-1137 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1151: Fonted download chinese garbled fix
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1151
Closed. Thanks for the reporting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1151: Fonted download chinese garbled fix
Posted by cquptEthan <gi...@git.apache.org>.
Github user cquptEthan commented on the issue:
https://github.com/apache/zeppelin/pull/1151
@Leemoonsoo OK .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1151: Fonted download chinese garbled fix
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1151
Thanks @cquptEthan. I'm merging it into master and branch-0.6 if there is no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1151: Fonted download chinese garbled fix
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1151: Fonted download chinese garbled fix
Posted by cquptEthan <gi...@git.apache.org>.
Github user cquptEthan commented on the issue:
https://github.com/apache/zeppelin/pull/1151
@Leemoonsoo Thanks.
I've created [ZEPPELIN-1138](https://issues.apache.org/jira/browse/ZEPPELIN-1138) for it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1151: Fonted download chinese garbled fix
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1151
Tested and confirmed it fixes the problem.
@cquptEthan thanks for the contribution.
Do you mind create a jira issue for it?
Then I'd like to mark fix version 0.6.1 and merge it into master, branch-0.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---